PRS in Tanasee1 - no. 8 #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRS in Tanasee1 as discussed and revised in Pull request #742.
eu-genia
requested changes
Nov 6, 2023
new/PRS14107Mangasha.xml
Outdated
| <persName xml:lang="gez" xml:id="n1">መንገሻ</persName> | ||
| <persName xml:lang="gez" type="normalized" corresp="#n1">Mangašā</persName> | ||
| <persName xml:lang="gez"><roleName type="title">rās</roleName></persName> | ||
| <occupation type="military">bit wadad</occupation> |
There was a problem hiding this comment.
You mean, I should insert the gemination of d and transform the occupation to a title?
| <persName xml:lang="gez" xml:id="n1">ብሩ</persName> | ||
| <persName xml:lang="gez" type="normalized" corresp="#n1">Bərru</persName> | ||
| <persName xml:lang="gez"><roleName type="title">liqa rad</roleName></persName> | ||
| </person> |
There was a problem hiding this comment.
any date? here and elsewhere
There was a problem hiding this comment.
I refrained from offering a date because I felt it would be too imprecise and uncertain to offer a date.
new/PRS14117Zallaqa.xml
Outdated
| <person sex="1"> | ||
| <persName xml:lang="gez" xml:id="n1">ዘለቀ</persName> | ||
| <persName xml:lang="gez" type="normalized" corresp="#n1">Zallaqa</persName> | ||
| <occupation type="political">blāttā</occupation> |
There was a problem hiding this comment.
I changed occupation to title.
I updated the records according to Eugenias requests.
thea-m
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRS in Tanasee1 as discussed and revised in Pull request #742.