🔧 build(expath): make deps explicit #21
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
line-o
reviewed
Aug 25, 2022
| @@ -1,5 +1,10 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <package xmlns="http://expath.org/ns/pkg" name="https://www.betamasaheft.uni-hamburg.de/BetMas" abbrev="BetaMasaheft" version="5.0" spec="1.0"> | |||
| <title>Beta maṣāḥǝft: Manuscripts of Ethiopia and Eritrea</title> | |||
| <dependency package="http://exist-db.org/apps/shared"/> | |||
| <dependency package="http://exist-db.org/apps/shared" semver-min="0.9.1"/> | |||
| <dependency package="https://betamasaheft.eu/betmasweb/" semver-min="0.1"/> | |||
There was a problem hiding this comment.
I wonder why BetMas - as the legacy application - depends on its successor betmasweb?
Will this not introduce a circular dependency, when the hidden dependency in betmasweb on betmas is declared?
There was a problem hiding this comment.
yes it will, so before we actually deploy anything we need to resolve these properly. But my goal for now is to declare the current status, warts n all .
check versions of deployed apps vs those in this repo make explicit dep declarations including to shared-resources TODO: likely incomplete see BetaMasaheft/Documentation#2180
duncdrum
force-pushed
the
feat_expath_prod
branch
from
66404e9
to
9c4ced9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check versions of deployed apps vs those in this repo
make explicit dep declarations including to shared-resources
TODO: likely incomplete
see BetaMasaheft/Documentation#2180