Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean car models code, change endpoint #30

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Clean car models code, change endpoint #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d9c6e4
Chore: change field name
Rivixer Jun 22, 2024
6c2669e
Change car models endpoint
Rivixer Jun 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/main/java/com/example/backend/car/controller/CarController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,20 @@
@RequestMapping("/api/cars")
public class CarController {

private final CarService carBrandService;
private final CarService carService;

public CarController(CarService carBrandService) {
this.carBrandService = carBrandService;
public CarController(CarService carService) {
this.carService = carService;
}

@GetMapping("list")
public List<CarBrandDto> get() {
return carBrandService.list().stream().map((carBrand) -> CarBrandDto.of(carBrand.getId(), carBrand.getName(), carBrand.getSearchKey())).toList();
return carService.list().stream().map((carBrand) -> CarBrandDto.of(carBrand.getId(), carBrand.getName(), carBrand.getSearchKey())).toList();
}

@GetMapping("/{brand_id}")
public List<CarModelDto> getModels(@PathVariable("brand_id") Integer brandId) {
return carBrandService.getModels(brandId).stream()
@GetMapping("{id}/models")
public List<CarModelDto> getModels(@PathVariable("id") Integer brandId) {
return carService.getModels(brandId).stream()
.map(carModel -> CarModelDto.of(
carModel.getId(),
carModel.getName(),
Expand Down