Enhance parameter filtering in get_optional_params_image_gen to prevent unsupported parameters from being added to extra_body for Azure GPT image generation #15077
+100
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt unsupported parameters from being added to extra_body for Azure GPT image generation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
hi @Dashing-Nelson, thank you for this PR! i think we already have a reusable function for this logic - why not use that? Also - your currently failing linting - if you can look into that, that'd be great! |
…arameters for improved handling of unsupported arguments
…for image generation by introducing helper functions for provider-specific logic
…rams variable and streamline argument validation logic
…arameters for improved handling of unsupported arguments
…image_gen function, streamlining parameter processing for image generation
…or_image_gen function, enhancing filtering of provider-specific parameters for image generation
@krrishdholakia I have made use of the function and modified I also noticed that linting and the test cases are failing for functions that are not related to mine. |
…ams with dropped_params for improved handling of unsupported parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
This pull request improves parameter handling for Azure GPT image generation models to prevent unsupported parameters from being included in API requests, which previously could cause errors. It also adds a new test to ensure this behavior is maintained.
Parameter filtering improvements:
_check_valid_arginlitellm/utils.pyto filter out unsupported parameters frompassed_paramswhendrop_paramsis enabled, ensuring only supported parameters are included in API requests. This prevents issues like sendingresponse_formatto Azure'sgpt-image-1model, which can result in 400 Bad Request errors.Testing enhancements:
test_azure_gpt_image_1_no_extra_body_injectionintests/test_litellm/test_utils.pyto verify that unsupported parameters (such asresponse_format) are dropped and not injected intoextra_bodywhen using provider config with Azure GPT image generation, and that supported parameters are preserved.Relevant issues
Fixes #15028
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
Changes
Azure OpenAI Reject Image Generation Payload Due to extra_body Injection in LiteLLM v1.77.3 for gpt-image-1