fix: sonnet 3.5 should not report support of reasoning_effort #12836
+23
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ishaan-jaff
requested changes
Jul 21, 2025
| "web_search_options", | ||
| ] | ||
|
|
||
| if "claude-3-7-sonnet" in model or supports_reasoning( |
There was a problem hiding this comment.
please keep the "if "claude-3-7-sonnet" LOC here
There was a problem hiding this comment.
Doesn't that basically override what someone might have configured with supports_reasoning in their config file?
There was a problem hiding this comment.
This change as-is retains the default behavior because that model has "supports_reasoning": true in the config map.
litellm/model_prices_and_context_window.json
Line 5865 in 1b05ea7
|
fix with no test cherry-picked to #12847 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12833
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsType
🐛 Bug Fix
✅ Test