Skill Set functionality and CFire Performance #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FireSystem_ExtinguishInRadius seems to be unused, I think most of this logic can be removed, among other misc fire.cpp functions, FireSystem_AddHeatInRadius on the other hand is used in entity flame but is not necessary, this could be removed too, ignite logic is not used a lot in BB2, the M1A1 tank will in rare cases ignite some entities, but that's it, I guess some refactoring could be done in entity flame, but I suppose this stuff could be moved to a different pull request, as it has nothing to do with skill tree sets? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realize that the skill sets aren't implemented in the game yet (where the player can access them), but leaving the functionality would be ideal since it would be quicker to implement a VGUI if we have the backend work already finished.
The CFire optimizations include the removal of useless hull traces, drastically increasing server performance when entities are ignited.
I also updated the .gitignore with my preferences, so feel free to discard that change.