Fix isSubmitted() of AbstractElement

BerliozFramework · Nov 22, 2024 · b6aaffc · b6aaffc
1 parent 1aabc3e
commit b6aaffc
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/src/Element/AbstractElement.php b/src/Element/AbstractElement.php
@@ -350,9 +350,13 @@ public function setTransformer(TransformerInterface $transformer): void
      */
     public function isSubmitted(): bool
     {
-        $form = $this->getForm();
+        $submittedForm = $this->getForm()?->isSubmitted();
 
-        return $form?->isSubmitted() ?? $this->submitted;
+        if (true === $submittedForm) {
+            return $this->submitted;
+        }
+
+        return $submittedForm ?? $this->submitted;
     }
 
     /**

diff --git a/tests/HydratorTest.php b/tests/HydratorTest.php
@@ -198,7 +198,7 @@ public function testHydrateCollectionWithGroupEmpty()
         $person
             ->setAddresses(
                 [
-                    (new FakeAddress())
+                    $expectedAddress = (new FakeAddress())
                         ->setAddress('2 avenue Paris')
                         ->setAddressNext('BP 12345')
                         ->setZipCode('75001')
@@ -234,7 +234,7 @@ public function testHydrateCollectionWithGroupEmpty()
         $hydrator = new FormHydrator($form);
         $hydrator->hydrate($person);
 
-        $this->assertEquals([], $person->getAddresses());
+        $this->assertEquals([$expectedAddress], $person->getAddresses());
     }
 
     public function testPartialMapped()

diff --git a/tests/Type/AbstractTypeTest.php b/tests/Type/AbstractTypeTest.php
@@ -158,7 +158,7 @@ public function testValue()
 
         $type->setValue('test');
         $this->assertSame('test', $type->getValue());
-//
+
         $type->submitValue('bar');
         $this->assertSame('bar', $type->getValue());