AP-464: Integrate prisma into the app image #70
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danschmidt5189
force-pushed
the
AP-464-prisma_integration_refactoring
branch
from
17fac42 to
b2b052c
Compare
danschmidt5189
force-pushed
the
AP-464-prisma_integration_refactoring
branch
from
97bace6 to
f4dfea5
Compare
awilfox
requested changes
Oct 6, 2025
There was a problem hiding this comment.
Adding 360M to the resultant image seems like a huge loss when we are already trying to make the image smaller (and I've been doing some work to remove about 300M from it) so that the GitHub Actions cache can actually work.
It also adds a lot of maintenance overhead and security considerations (Node's LTS branches, NPM packages, etc) for no real gain over just including the static SQL. Upstream seems averse to changing their data layer even in minor ways that would give them significant gains, so I don't foresee future migrations beyond the one we have. If they do begin using migrations, we should re-evaluate then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates chainlit's official prisma data layer into the primary application image and tests it in the pipeline. This adds about 360M to the resulting image:
The existing prisma image is ~880MB.