AP-452: Updates the build workflow #68
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the build workflow to optimize Docker build and deployment processes. The changes focus on improving build efficiency, simplifying test execution, and streamlining the image tagging and pushing process.
Key changes:
- Adds multi-platform build support (linux/amd64, linux/arm64) and reorganizes build parameters
- Simplifies test execution by using docker compose exec instead of separate container runs
- Replaces Docker build-push action with direct Docker CLI commands for final image tagging
| target: app | ||
| run: | | ||
| docker pull "$DOCKER_APP_IMAGE" | ||
| echo "$DOCKER_METADATA_OUTPUT_TAGS" | tr ' ' '\n' | xargs -n1 docker tag "$DOCKER_APP_IMAGE" |
There was a problem hiding this comment.
The variable DOCKER_METADATA_OUTPUT_TAGS is referenced but not defined. This variable should be set from the metadata action outputs, likely ${{ steps.branch-meta.outputs.tags }}.
Copilot uses AI. Check for mistakes.
.github/workflows/build.yml
Outdated
| cache-from: type=gha | ||
| cache-to: type=gha |
There was a problem hiding this comment.
The cache configuration has been moved but the target: development parameter was removed. If this build step should still target the development stage, the target parameter should be retained.
Copilot uses AI. Check for mistakes.
1 participant
No description provided.