Ada 225: Function cannot be performed by keyboard alone #17
Conversation
src/components/Facets.vue
Outdated
| function handleWindowResize() { | ||
| isMobile.value = window.innerWidth <= 700 | ||
| if (isMobile.value) { |
There was a problem hiding this comment.
Won't this hide/show them on any resize then? For instance, if a user has already showed them, then turns the phone landscape, the view will still be mobile (the logical resolution of my older iPhone is 375x667) but the facets will close on device rotation. Similarly, if a user is dragging a Firefox/Safari window on a desktop computer, it will open/close dynamically on each size event.
This might be the desired behaviour, but it's something to think on. I wonder about both POLA and accessibility here.
There was a problem hiding this comment.
@awilfox Thanks again for catching this! I've updated the workflow, this issue should be fixed.
jason-raitz
left a comment
jason-raitz
left a comment
There was a problem hiding this comment.
lgtm. It's ready to check on staging.
Replace the checkbox and label with an option button for the galc form used in mobile interface