Skip to content

AP-487: correctly declare mime type for mp3s #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
Merged

AP-487: correctly declare mime type for mp3s #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/berkeley_library/av/types/file_type.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def raise_if_duplicate(extensions)
# ############################################################
# Enum members

new(:MP3, 'audio', 'application/x-mpegURL', extensions: MP3_EXTENSIONS)
new(:MP3, 'audio', 'audio/mpeg', extensions: MP3_EXTENSIONS)
new(:MP4, 'video', 'video/mp4', extensions: MP4_EXTENSIONS)
new(:UNKNOWN, 'object', 'application/octet-stream', label: 'Unknown')

Expand Down
2 changes: 1 addition & 1 deletion spec/lib/berkeley_library/av/types/file_type_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module Types
describe :mime_type do
it 'is correct' do
expected = {
FileType::MP3 => 'application/x-mpegURL',
FileType::MP3 => 'audio/mpeg',
FileType::MP4 => 'video/mp4',
FileType::UNKNOWN => 'application/octet-stream'
}
Expand Down