Fix issue finding GetFieldDefaultValue on 2021.3.23 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@limoka can you rebase? |
limoka
force-pushed
the
fix_finding_get_field_default_value
branch
from
4e6132e to
37168ce
Compare
|
@ds5678 rebased as you asked. Sorry it took a while, I was busy with IRL things. |
ds5678
requested changes
Jan 16, 2025
Il2CppInterop.Runtime/Injection/Hooks/Class_GetFieldDefaultValue_Hook.cs
Outdated
Show resolved
Hide resolved
Il2CppInterop.Runtime/Injection/Hooks/Class_GetFieldDefaultValue_Hook.cs
Show resolved
Hide resolved
Il2CppInterop.Runtime/Injection/Hooks/Class_GetFieldDefaultValue_Hook.cs
Outdated
Show resolved
Hide resolved
Il2CppInterop.Runtime/Injection/Hooks/Class_GetFieldDefaultValue_Hook.cs
Outdated
Show resolved
Hide resolved
|
@ds5678 addressed your comments. You can have a look at why these changes were made in these Discord messages. https://discord.com/channels/623153565053222947/623153565661265952/1104817110888235018 This message in particular shows exactly the situation in which this check is triggered. A correct match should not contain more than 4 jumps, at least on metadata version 30 and below (IDK about further versions, this needs more testing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
Class::GetDefaultFieldValue()is not found by signature and traversal search returns wrong value because of compiler optimization.Added a check for such optimization and added the signature from the game where issue occured.
Tested on Idle Slayer Unity 2021.3.23 and Core Keeper Unity 2021.3.14