Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla Item Extension #302

Open
wants to merge 83 commits into
base: master
Choose a base branch
from
Open

Conversation

DANRULEZ123
Copy link

35 New Items

  • Armor Trim Templates
  • Stuff from trial chamber update
  • Echo & Amethyst Shards
  • more

Added Echo Shards and Amethyst Crystals to item id map.
Add Echo Shard & Amethyst Crystal Item IDs.
Added Echo Shards & Amethyst Crystals to registered ids.
Removed getName()
Remove getName()
Changed amethyst_crystal to amethyst_shard to correct error.
AMETHYST_CRYSTAL -> AMETHYST_SHARD
# Details:
- 18 Armor Trim Templates (items)
- 15 Other Vanilla Items
Registered new vanilla items.
Forgot SnifferEgg lol...
Fix invalid ID.
Fixed missing comma
Reverted to original
@KnosTx
Copy link

KnosTx commented Nov 30, 2024

I think there is a lack of implementation.

@DANRULEZ123
Copy link
Author

I think there is a lack of implementation.

Alright, what do you suggest adding then?

1.21.50 - Added Resin Clump & Resin Brick items.
No extra functionality needed.
No extra functionality needed.
No extra functionality needed.
No extra functionality needed.
Changed comment, the brushing animation already occurs.
Added the default bundle (in the last commit.) This commit has added all the color varients.
Added missing use statements. (pocketmine\item\Item & ItemFactory)
Iron Ore now drops raw iron.
Fixed typo that remained unnoticed for 4 years.
Attempt at making raw ores smeltable.
@DANRULEZ123
Copy link
Author

This should be stable enough to merge now.

TO-DO:

  • Implement full mace functionality
  • Implement Wind Charge entities
  • Modify Wind Charge Item to spawn the wind charge upon activating.

Changes

  • As requested, removed tons of unnecessary Item objects. Only keeping the ones that require additional functionality.
  • Added Bundles, along with their color variants.
  • Attempted to make raw ores smeltable by adding them to recipes.json.
  • Added more blocks to item_id_map.json (still needs implemented into block_id_map.json
  • Iron and Gold Ores now drop their respective raw materials.

Implemented 123 new block ids! (Use extended blocks to register and use)
@DANRULEZ123
Copy link
Author

DANRULEZ123 commented Jan 15, 2025

Vanilla Block ID Extension:

Added 123 new blocks to block_id_map, once implemented, they should be usable via ExtendedBlocks.

TO-DO:

  • Implement full mace functionality
  • Implement Wind Charge entities
  • Modify Wind Charge Item to spawn the wind charge upon activating.
  • Register The Bundle along with its respective color variants.

Added previously implemented IDs that weren't here from item_id_map.json.
Remove unnecessary comment
Registered previously added items. (936-954)
@DANRULEZ123
Copy link
Author

New Items Registered

Registered block ids from 937-954.

  • Resin Bricks
  • Resin Clumps
  • Bundles (and their respective colors.) (938-954)


// Register newer items.
self::registerItem(new Item(Item::ECHO_SHARD, 0, "Echo Shard"));
//self::registerItem(new Item(Item::AMETHYST_CRYSTAL, 0, "Amethyst Crystal"));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no AMETHYST_CRYSTAL constant

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

therefore, i commented it out (see my last commit)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the issue. It was supposed to be AMETHYST_SHARD.

use pocketmine\block\Block;
use pocketmine\Player;

class RawCopper extends Item {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no point of this class

use pocketmine\block\Block;
use pocketmine\Player;

class RawGold extends Item {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as for RawCopper

use pocketmine\block\Block;
use pocketmine\Player;

class RawIron extends Item {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as for RawCopper

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to remove them because I was trying to make them smeltable which wasn't possible through those classes.

@DANRULEZ123
Copy link
Author

Fixes

  • Fixed invalid constant for Amethyst Crystal/Shard
  • Removed Raw Iron, Gold, and Copper classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants