-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 91742: Application error - no tabs #25
Conversation
Add variables in the workflow which will be replaced with the values saved in your Github sercets. |
Note the margin/padding needed @akash2017sky :-) |
I think I need a PR for the workflow with instructions for the secrets @akash2017sky? We should be deploying from this |
What is the Bug ID for this one please @EdiWeeks? |
@BenGWeeks |
Enhancement: Rename |
variables are being populated, but a warning message is appearing in Teams. |
Did a little look into this: I also don't see the same tabs as you? I assume the solutions should work when you are running locally too? Check the secrets, as their are environment variables missing. Also, make sure you are liaising with @akash2017sky on this as both working on the deployment flow atm. |
@BenGWeeks make sure your manifest file for the bot is the latest. |
Any changes would (should) be in the PR? |
Code is in the PR. Screenshot is from the file changes listed. |
Bug 91800 MS Teams shows blank error banner has been opened, The issue requires additional time to resolve. |
OK, I think we see it on the homepage due to load times: Low priority on the warning though, as have a call with LNbits crowd tomorrow and @arcbtc is going to fix it for us :-P |
Will need to test pipeline after merge. |
Changes to Web App
Updates in Bot Manifest File
Added Additional Tabs: Feed, Users, Rewards, Wallet
The content URL for each tab needs to be updated to correct environment. currently this is hardcoded in the manifest files.
Make sure you have added the web url as a Valid Domain in the file and the url has to be HTTPS, HTTP will not work.
Deployment Pipelines
Added new WriteEnv.js which will append the .env files with the LNBits variable in the env.dev file.
In the file we are only selecting selected variables, as the other variables related to MS Teams bot Framework
All environment variables have to be stored in GitHub Secrets, which will then set the variables during deployment.