Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 91742: Application error - no tabs #25

Merged
merged 17 commits into from
Oct 1, 2024

Conversation

desousamario85
Copy link
Collaborator

@desousamario85 desousamario85 commented Sep 26, 2024

Changes to Web App

  • Added staticwebapp.config.json which helps with the routing and allows users to navigate directly to a page in the address bar. This also resolves the issue where in the bot framework , the tabs were showing 404 errors.

Updates in Bot Manifest File

Added Additional Tabs: Feed, Users, Rewards, Wallet
The content URL for each tab needs to be updated to correct environment. currently this is hardcoded in the manifest files.
Make sure you have added the web url as a Valid Domain in the file and the url has to be HTTPS, HTTP will not work.

Deployment Pipelines
Added new WriteEnv.js which will append the .env files with the LNBits variable in the env.dev file.
image
In the file we are only selecting selected variables, as the other variables related to MS Teams bot Framework

All environment variables have to be stored in GitHub Secrets, which will then set the variables during deployment.

@desousamario85
Copy link
Collaborator Author

Values are blank due to environment variables not being set.
Visual of the bot with the web app pages embedded.
image

@desousamario85
Copy link
Collaborator Author

Add variables in the workflow which will be replaced with the values saved in your Github sercets.
Each variable must be called the following names.
REACT_APP_LNBITS_NODE_URL
REACT_APP_LNBITS_USERNAME
REACT_APP_LNBITS_PASSWORD
REACT_APP_LNBITS_ADMINKEY
REACT_APP_LNBITS_STORE_ID
REACT_APP_TENANT_ID
REACT_APP_AAD_CLIENT_ID

@BenGWeeks
Copy link
Owner

Values are blank due to environment variables not being set. Visual of the bot with the web app pages embedded. image

Note the margin/padding needed @akash2017sky :-)

@BenGWeeks
Copy link
Owner

Add variables in the workflow which will be replaced with the values saved in your Github sercets. Each variable must be called the following names. REACT_APP_LNBITS_NODE_URL REACT_APP_LNBITS_USERNAME REACT_APP_LNBITS_PASSWORD REACT_APP_LNBITS_ADMINKEY REACT_APP_LNBITS_STORE_ID REACT_APP_TENANT_ID REACT_APP_AAD_CLIENT_ID

I think I need a PR for the workflow with instructions for the secrets @akash2017sky? We should be deploying from this main please.

@BenGWeeks
Copy link
Owner

What is the Bug ID for this one please @EdiWeeks?

@EdiWeeks
Copy link
Collaborator

@BenGWeeks
Bug 91742: Application error - no tabs

@BenGWeeks BenGWeeks changed the title BUG: Unable to navigate pages in Bots via the tabs Bug 91742: Application error - no tabs Sep 27, 2024
@BenGWeeks
Copy link
Owner

Add variables in the workflow which will be replaced with the values saved in your Github sercets. Each variable must be called the following names. REACT_APP_LNBITS_NODE_URL REACT_APP_LNBITS_USERNAME REACT_APP_LNBITS_PASSWORD REACT_APP_LNBITS_ADMINKEY REACT_APP_LNBITS_STORE_ID REACT_APP_TENANT_ID REACT_APP_AAD_CLIENT_ID

Enhancement: Rename REACT_APP_STORE_OWNER_EMAIL to REACT_APP_LNBITS_STORE_OWNER_EMAIL to be consistent
Assigned to: @NataliaMilgevskaya
FYI @EdiWeeks

@desousamario85
Copy link
Collaborator Author

variables are being populated, but a warning message is appearing in Teams.
image
@BenGWeeks FYI

@BenGWeeks BenGWeeks added this to the MVP milestone Sep 27, 2024
@BenGWeeks
Copy link
Owner

Did a little look into this:

image

I also don't see the same tabs as you?

I assume the solutions should work when you are running locally too?

Check the secrets, as their are environment variables missing.

Also, make sure you are liaising with @akash2017sky on this as both working on the deployment flow atm.

@desousamario85
Copy link
Collaborator Author

@BenGWeeks make sure your manifest file for the bot is the latest.
It should contain the below.

image

@BenGWeeks
Copy link
Owner

Any changes would (should) be in the PR?

@desousamario85
Copy link
Collaborator Author

Code is in the PR. Screenshot is from the file changes listed.

@desousamario85 desousamario85 marked this pull request as ready for review September 30, 2024 11:13
@desousamario85
Copy link
Collaborator Author

Bug 91800 MS Teams shows blank error banner has been opened, The issue requires additional time to resolve.

@BenGWeeks
Copy link
Owner

Do you think that pop-up is about cookies?

image

Alternatively, is it bubbling up the console.warnings?

image

image

Perhaps try changing console.warning in lnbitsServiceLocal to a console.log first.

appPackage/manifest.json Outdated Show resolved Hide resolved
@BenGWeeks
Copy link
Owner

BenGWeeks commented Sep 30, 2024

OK, I think we see it on the homepage due to load times:

image

Low priority on the warning though, as have a call with LNbits crowd tomorrow and @arcbtc is going to fix it for us :-P

@BenGWeeks
Copy link
Owner

Will need to test pipeline after merge.

@BenGWeeks BenGWeeks merged commit 4389517 into BenGWeeks:main Oct 1, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants