Fix extra vertical line on Zelos hat blocks#385
Draft
google-labs-jules[bot] wants to merge 2 commits intodevelopfrom
Draft
Fix extra vertical line on Zelos hat blocks#385google-labs-jules[bot] wants to merge 2 commits intodevelopfrom
google-labs-jules[bot] wants to merge 2 commits intodevelopfrom
Conversation
Blocks with hats in the Zelos renderer would sometimes have an extra vertical line segment drawn on their right side when no block was connected below them. This was caused by the `drawTop_` method in the common drawer unconditionally drawing a vertical line for the top row, which was not coordinated with the rest of the block's path drawing for this specific case. The fix is to override `drawTop_` in the Zelos drawer and only draw the vertical line if the block does not have a hat, or if a block is connected to its next connection. This is determined by checking the `isConnected()` status of the next connection.
Blocks with hats in the Zelos renderer would sometimes have an extra vertical line segment drawn on their right side when no block was connected below them. This was caused by the `drawTop_` method in the common drawer unconditionally drawing a vertical line for the top row, which was not coordinated with the rest of the block's path drawing for this specific case. The fix is to override `drawTop_` in the Zelos drawer and only draw the vertical line if the block does not have a hat, or if a block is connected to its next connection. This is determined by checking the `isConnected()` status of the next connection.
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. I will automatically address your comments and implement changes based on your feedback. For any comments you don't want me to act on, just include For security, I will only act on instructions from the user who triggered this task for this pull request. |
BeksOmega
reviewed
Aug 30, 2025
Owner
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
Can you also run a frontend verification on this?
| } | ||
| } | ||
|
|
||
| protected override drawTop_() { |
Owner
There was a problem hiding this comment.
I don't think the changes are needed at the zelos level, I think they need to be one level up in the common/drawer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a visual bug in the Zelos renderer where blocks with hats had an extra vertical line on their right side.
The fix involves overriding the
drawTop_method in the Zelos drawer to conditionally draw the right-side vertical line of the top row. The line is now only drawn if the block does not have a hat, or if there is a block actively connected to its next connection.