Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort projectiles fx.dm better #2675

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Kenionatus
Copy link
Contributor

About The Pull Request

Should make it a bit less likely that people (like me) overlook some procs that were far away from their datum.
Also turns some comments into doc comments. Only single character changes this time, no moving of comments (so code style stays the same as before). This now works because the extension is now fixed and propperly handles //! marked same line doc comments. (On the other hand, it might have broken /// above line doc comments? I don't think that really matters for this PR tho.)
Also adds like one additional empty line somewhere for separation.

Why It's Good For The Game

Makes code easier to read.

Testing Photographs and Procedure

Screenshots&Videos VSCode tells me that the removals are all code movements instead of actual removal. ![image](https://github.com/BeeStation/NSV13/assets/54814353/dd0ccdca-49c4-49eb-b33c-0850c05e0b7f)

Changelog

馃啈
refactor: projectiles_fx.dm should now be slightly more readable
/:cl:

Should make it a bit less likely that people (like me) overlook some procs that were far away from their datum.
Only single character changes this time, not moving of comments. This is because the extension is now fixed and propperly handles //! marked same line doc comments. On the other hand, it might have broken /// above line doc comments?
Also adds like one additional empty line somewhere for separation.
It's no longer in a file that's shared with Bee so it doesn't need the marker.
@Kenionatus
Copy link
Contributor Author

Kenionatus commented Jun 4, 2024

Bruh, did the image upload not work? Hm, file is there, just the embedding is broken?

@Ikalpo
Copy link
Contributor

Ikalpo commented Jun 25, 2024

Bruh, did the image upload not work? Hm, file is there, just the embedding is broken?

It's because you wrote between these lines

<details>
<summary>Screenshots&Videos</summary>
>>HERE<<
![image](https://github.com/BeeStation/NSV13/assets/54814353/dd0ccdca-49c4-49eb-b33c-0850c05e0b7f)

</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants