fix auto recall warnings not made during combat #2673
Draft
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reminder stacks were increased but the increase would not be commnunicated to the players if they were in combat during it, leading to auto recall announcements being missable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reminder stacks were increased but the increase would not be commnunicated to the players if they were in combat during it, leading to auto recall announcements being missable.
Opening this as draft for now in case I get sidetracked before I can properly rework it.
fixes #2672
Why It's Good For The Game
Players not knowing that auto recall is approaching is bad because surprise auto recall is lame. This makes sure that the time is always available to the players.
Testing Photographs and Procedure
Admin completed initial objectives, voted for extension, set next_objective_reminder low enough to get a reminder (got a reminder), spawned in a pirate fleet in current system, set next_objective_reminder low again, (got a reminder), set it low again (got the "recall delayed due to combat message"), waited 10 minutes, got auto recalled. (I believe the 10 minutes wait after the recall is delayed are not related to this PR.)
Changelog
🆑
fix: Auto recall reminders now also get sent during combat
/:cl: