Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @eslint-react and fix issues #535

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add @eslint-react and fix issues #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dea105c
fix: improve react code based on @eslint-react plugin
ivan-dalmet Oct 2, 2024
54824f0
fix: add useValueHasChanged hook
ivan-dalmet Oct 3, 2024
4d15427
Merge branch 'master' into fix/improve-react-code
ivan-dalmet Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"next/core-web-vitals",
"plugin:storybook/recommended"
],
"plugins": ["@eslint-react/eslint-plugin"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Plugin "@eslint-react/eslint-plugin" is listed in package.json but not installed in node_modules.

  • Please install the plugin by running npm install or the appropriate package manager command.
🔗 Analysis chain

LGTM! Verify plugin installation.

The addition of the "@eslint-react/eslint-plugin" aligns with the PR objectives and is a good step towards improving React-specific linting.

Please run the following script to verify the plugin installation:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify @eslint-react/eslint-plugin installation

# Test: Check if the plugin is listed in package.json
if jq -e '.devDependencies["@eslint-react/eslint-plugin"]' package.json > /dev/null; then
    echo "Plugin is listed in package.json"
else
    echo "Plugin is not listed in package.json"
fi

# Test: Check if the plugin is installed in node_modules
if [ -d "node_modules/@eslint-react" ]; then
    echo "Plugin is installed in node_modules"
else
    echo "Plugin is not installed in node_modules"
fi

Length of output: 392

Script:

#!/bin/bash
# Description: Verify @eslint-react/eslint-plugin installation

# Test: Check if the plugin is listed in package.json
if grep -q '"@eslint-react/eslint-plugin"' package.json; then
    echo "Plugin is listed in package.json"
else
    echo "Plugin is not listed in package.json"
fi

# Test: Check if the plugin is installed in node_modules
if [ -d "node_modules/@eslint-react/eslint-plugin" ]; then
    echo "Plugin is installed in node_modules"
else
    echo "Plugin is not installed in node_modules"
fi

Length of output: 272

"rules": {
"react/no-unescaped-entities": "off",
"@typescript-eslint/no-unused-vars": [
Expand All @@ -18,6 +19,10 @@
"sonarjs/prefer-immediate-return": "warn"
},
"overrides": [
{
"files": ["**/*.{ts,tsx}"],
"extends": ["plugin:@eslint-react/recommended-legacy"]
},
{
"files": ["./src/**/*.*"],
"rules": {
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@
"@babel/eslint-parser": "7.24.7",
"@babel/parser": "7.24.7",
"@chakra-ui/cli": "2.4.1",
"@eslint-react/eslint-plugin": "1.14.3",
"@next/eslint-plugin-next": "14.2.4",
"@playwright/test": "1.45.1",
"@storybook/addon-actions": "8.1.11",
Expand Down
Loading
Loading