Mistyped property for SoapClient options #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attachment type is set to wrong class property. It should set "attachment_type" option to "soapOptions" class property, not to "options". Since "soapOptions" is passed to BeSimple\SoapClient\SoapClient constructor and latter to configureMime() where it is being checked for 'attachment_type' option
|
PHP 5.6 build fails because of deprecated messages which are outputed when PHP receives POST data. |
Added PHP configuration option `always_populate_raw_post_data = -1` for PHP v5.6. Since by default it is set to `0` and if PHP receives POST data with not `Content-type: application/x-www-form-urlencoded` deprecated message is thrown which fails Travis build
|
+1 on merging this. Renaming |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attachment type is set to wrong class property.
It should set
attachment_typeoption tosoapOptionsclass property, not tooptions.Since
soapOptionsis passed toBeSimple\SoapClient\SoapClientconstructor and later toconfigureMime()where it is checked forattachment_typeoption.optionsclass property does not do anything.