-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: optional scopes in refresh token #169
base: main
Are you sure you want to change the base?
fix: optional scopes in refresh token #169
Conversation
…copes when trying to refresh token
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 21.28% 21.22% -0.06%
==========================================
Files 63 62 -1
Lines 1809 1809
==========================================
- Hits 385 384 -1
- Misses 1424 1425 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while this solves the specific issue of removing scope from refresh token, I think we need a more general solution for modifying the requests before sending them for any other use case that pops up
I think that is a little bit difficult to manage these issues in a more generic way, because every idp can manage the optional parameters of the different endpoints in different ways. |
That would of course be even better, I agree with you @ahmednfwela. But that's time-consuming and takes quite a while, right? |
Description
This fix proposes the introduction of a new attribute of the UserManagerSettings class that would be used during the flow of refresh token to decide whether or not to include the scopes as param in the body of the request.
This fix is needed, as I pointed out in #167, because Salesforce doesn't support scope parameter in the body request when refreshing token.
Type of Change