Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network rebuild #60

Open
wants to merge 10 commits into
base: TM2.1
Choose a base branch
from
Open

Network rebuild #60

wants to merge 10 commits into from

Conversation

i-am-sijia
Copy link
Collaborator

network-rebuild branch has commits that have not been merged into the develop branch. This PR is to bring those commits in.

@i-am-sijia i-am-sijia marked this pull request as ready for review October 18, 2022 22:26
@DavidOry DavidOry changed the base branch from develop to TM2.1 June 13, 2024 19:38
@DavidOry
Copy link
Collaborator

@i-am-sijia
What is the status of these changes? I've re-based the PR to pull into the TM2.1 branch. Are these still relevant?

Copy link
Collaborator Author

@i-am-sijia i-am-sijia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR includes the following that are not incorporated in the TM2.1 version (Cube). These are no longer needed in the TM2.2 EMME-tm2py version.

  • The updated free flow speed and capacity lookup by capclass. The new network has different facility type definitions compared to the old one, hence the lookup is updated. This is taken care in the TM2.2 (tm2py)
  • VDFs by facility type update to match the new facility types.
  • Removal of commented-out parts.
  • R scripts for processing transit on-board survey used for TAP-removal analysis.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the free flow speed lookup by capclass (10*area_atype+facility_type). The new network has new definitions of facility type, hence this lookup is updated in this PR. E.g., centroid connectors used to have FT=6, now they are FT=8.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly, this file also needs to be updated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VDFs are updated to match the new facility type definitions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yu-Chu fixed a typo in the parameter name. It was wrong in the old version.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the commented-out parts.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When exporting the 5 time-period specific networks, Yu-Chu changed lanes_@time_period@ to lanes (and also useclass, _fac_index, etc.). The main version did not. The main version had additional delays to certain facilities, e.g. bridge delays, that are not in this PR. It's probably better to use the main version.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yu-Chu's version removed the TAP conditions

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped blocks of code in comments.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Onboard survey processing scripts for TAP-removal analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants