-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network rebuild #60
base: TM2.1
Are you sure you want to change the base?
Network rebuild #60
Conversation
@i-am-sijia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR includes the following that are not incorporated in the TM2.1 version (Cube). These are no longer needed in the TM2.2 EMME-tm2py version.
- The updated free flow speed and capacity lookup by capclass. The new network has different facility type definitions compared to the old one, hence the lookup is updated. This is taken care in the TM2.2 (tm2py)
- VDFs by facility type update to match the new facility types.
- Removal of commented-out parts.
- R scripts for processing transit on-board survey used for TAP-removal analysis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the free flow speed lookup by capclass (10*area_atype+facility_type). The new network has new definitions of facility type, hence this lookup is updated in this PR. E.g., centroid connectors used to have FT=6, now they are FT=8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similarly, this file also needs to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The VDFs are updated to match the new facility type definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yu-Chu fixed a typo in the parameter name. It was wrong in the old version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the commented-out parts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When exporting the 5 time-period specific networks, Yu-Chu changed lanes_@time_period@
to lanes
(and also useclass
, _fac_index
, etc.). The main version did not. The main version had additional delays to certain facilities, e.g. bridge delays, that are not in this PR. It's probably better to use the main version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yu-Chu's version removed the TAP conditions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped blocks of code in comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Onboard survey processing scripts for TAP-removal analysis.
network-rebuild
branch has commits that have not been merged into thedevelop
branch. This PR is to bring those commits in.