Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNABM final files #44

Open
wants to merge 1 commit into
base: solano_napa
Choose a base branch
from

Conversation

binnympaul
Copy link
Collaborator

No description provided.

@lmz
Copy link
Member

lmz commented May 3, 2021

Hi - I have some issues I need to see resolved in this pull request

  1. There isn't any detail in the pull request. What are the major changes included in this pull request?
  2. There are a number of goto with comments about debugging or calibration in RunIteration.bat which look like they need to be removed
  3. There are hard-coded values committed to mtcTourBased.properties instead of having them remain as they were, set_by_RuntimeConfiguration.py. Why is this? I'd prefer not to have hardcoded values in config; they should be driven by input and set by RuntimeConfiguration.py
  4. Why is the jar file modified? There are no commits to .java files

@binnympaul
Copy link
Collaborator Author

Hi Lisa,

We have updated the setup based on your comments and will be issuing a new PR from RSG's account. The new PR will include details about major changes. All hard-coded values have been removed and other goto statements have been removed. Here are some responses to your comments:

The main updates for SNABM setup - more TAZs in Solano and Napa resulting in a total of 2376 TAZs, popsampler for intelligent sampling, network updates for Napa/Solano counties, and calibration and validation focused on Napa/Solano counties.
The JAR file was probably updated due to a recompile. Joel noted that the source files are the same.

This PR can be closed once a new PR from RSG's account is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants