Setup Model #168
Setup Model #168
Conversation
AshishKuls
requested review from
FlaviaTsang,
i-am-sijia,
e-lo and
lmz
as code owners
|
cc @lmz @FlaviaTsang @DavidOry Changes made to the setup process as per our last call. Here is the example setup config file for you to review and provide any further comments. |
…r than or equal to end iteration
|
|
||
| else: # iteration >=1 | ||
| elif (self.controller.iteration == 1) & (self.controller.config.warmstart.use_warmstart_skim): | ||
| # iteration = 1 and use_warmstart_skim = True : run uncongested transit assignment |
There was a problem hiding this comment.
Why so? is it to compromise for the fact that no warmstart transit assignment was run in global iteration 0, or is it to save run time?
There was a problem hiding this comment.
Yes, because when using the warm start with the skim option, we skip the transit skim and assignment in the global iteration 0. In iteration 1, the generated transit demand for an OD pair could be non-zero, even if the skim for that OD pair is zero in the warm start skim file (making it inconsistent), and thereby crashing in the congested transit assignment.
I ran into this above issue before making the code change.
|
Closes #150 |
What existing problem does the pull request solve and why should we include it?
Replicating the capabilities of
SetUpModelbatch file and creating tm2py methods to setup MTC travel model.Code formatting
Code should be PEP8 compliant before merging by running a package like
blackApplicable Issues
Please do not create a Pull Request without creating an issue first.
Issues List
SetUpModel.bat#150