Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding "skipLibCheck": true to thetsconfig.json. When we were ng building, angular material was throwing the bug:
Error: node_modules/saturn-datepicker/datepicker/datepicker.d.ts:57:22 - error TS2420: Class 'SatDatepicker' incorrectly implementCanColor'.
Property 'defaultColor' is missing in type 'SatDatepicker' but required in type 'CanColor'.
57 export declare class SatDatepicker implements OnDestroy, CanColor {
~~~~~~~~~~~~~
node_modules/@angular/material/core/common-behaviors/color.d.ts:15:5
15 defaultColor: ThemePalette | undefined;
~~~~~~~~~~~~
'defaultColor' is declared here.
An imported library (saturn-datepicker) had a bug in one of its files that wasn't allowing it to compile with angular material:
SaturnTeam/saturn-datepicker#157
This issue was still outstanding, and the only options to fix this and compile our project was to either edit the node_modules by hand, which each user would need to do manually, or add "skipLibCheck": true to the tsconfig.json. Here is what this setting does:
"Enabling --skipLibCheck can help work around these issues. Turning it on will prevent Typescript from type-checking the entire imported libraries. Instead, Typescript will only type-check the code you use against these types. This means that as long as you aren't using the incompatible parts of imported libraries, they'll compile just fine."
-https://stackoverflow.com/questions/52311779/usage-of-the-typescript-compiler-argument-skiplibcheck
We also should add this to the README, so that future groups know we made this setting change.