`shellcheck` all core files by gaelicWizard · Pull Request #1917 · Bash-it/bash-it

gaelicWizard · 2021-08-13T06:15:53Z

Description

Add custom, lib, scripts, and template to clean_files.txt and address the fallout. This helps towards #1696.

Motivation and Context

My entire glob branch would have been unnecessary if these files had been checked by spellcheck, so let's do it!

How Has This Been Tested?

All tests pass!

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

My code follows the code style of this project.
If my change requires a change to the documentation, I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
I have added tests to cover my changes, and all the new and existing tests pass.

gaelicWizard · 2021-08-13T06:17:08Z

This is a draft as it is a work-in-progress!

This branch is based on uname, basename, and brew, so those PRs are assumed to have been accepted before this one. (Otherwise there are a lot of unrelated changes in here!)

NoahGorny

Wow- what a great cleanup!
I look forward for merging all of your contributions @gaelicWizard 😄

Thanks for helping make Bash-it a better project ❤️

davidpfarrell

Hi Team !

IMO, this is too much risk for one PR : 24 files?

Lets try adding lib/ and scripts/ as separate PRs and see how that looks

gaelicWizard · 2021-08-15T00:11:53Z

IMO, this is too much risk for one PR : 24 files?

It's like six files, only one of which I've (partially) committed. The rest you see in the list are from a different PR, which has been approved but not merged yet. This PR is a draft because it's not ready yet.

Worry not, it will be clean and clear before submission! 👍

gaelicWizard · 2021-08-15T01:39:40Z

This is a draft as it is a work-in-progress!

This branch is based on uname, basename, and brew, so those PRs are assumed to have been accepted before this one. (Otherwise there are a lot of unrelated changes in here!)

(Just rebased on master since uname has been merged.)

gaelicWizard · 2021-09-09T07:16:10Z

All tests are passing, but this branch grew significantly so I will try to split it up a bit in separate PRs. The number of files actually changed here for shellcheck should be 7-10; the rest are from the prerequisite PRs that aren't merged yet.

gaelicWizard · 2021-09-20T20:31:08Z

Ok! This PR is still pretty big, but it's now narrowed down to specifically linting these files. I'm leaving it marked as draft as smaller PRs are more likely to go through sooner.

gaelicWizard · 2021-10-10T04:30:35Z

Rebased on current master. This PR no longer contains any unrelated changes to specifically shellcheck (and shfmt), as the prerequisite PRs have already been merged. 👍

The logic to guess whether to use `.bash_profile` or `.bashrc` was buggy and wrong. Just use `.bashrc` and either automatically fill in a `.bash_profile`, or notify the user that they need to edit their `.bash_profile`.

docs/installation: add to note about interactive/login shells

- Alsö, add implementation note at top.

uninstall: TIL that `fgrep` is deprecated...

- and generally comment out useless varbls

…lt enabling" This reverts commit e05fa47. This reverts commit ee85367.

c

seefood · 2024-11-10T14:49:28Z

Looks ready to go. just a merge from master, please.

seefood · 2025-08-10T06:37:13Z

seems abandoned for good...

gaelicWizard force-pushed the shellcheck branch from 4eaf435 to e9770ff Compare August 13, 2021 06:24

NoahGorny reviewed Aug 14, 2021

View reviewed changes

Comment thread clean_files.txt Outdated

davidpfarrell suggested changes Aug 14, 2021

View reviewed changes

gaelicWizard force-pushed the shellcheck branch 3 times, most recently from 7b3a445 to 5ea47b7 Compare August 15, 2021 01:09

gaelicWizard force-pushed the shellcheck branch 2 times, most recently from 42a0e6a to 9e55192 Compare August 15, 2021 04:15

gaelicWizard force-pushed the shellcheck branch 4 times, most recently from be58f3c to 5bebe44 Compare August 26, 2021 21:18

gaelicWizard force-pushed the shellcheck branch 15 times, most recently from 75d756a to a53776f Compare September 6, 2021 03:47

gaelicWizard force-pushed the shellcheck branch 3 times, most recently from 9cd57fd to 4a8b6f9 Compare September 9, 2021 01:37

This was referenced Sep 9, 2021

Lib/search: lint, cleanup, and small fixes #1932

Merged

Lint: prepare lib/utilities for shellcheck #1933

Merged

lib/helpers: lint, cleanup, & improvements #1934

Merged

gaelicWizard force-pushed the shellcheck branch from 4a8b6f9 to a223dfb Compare September 9, 2021 01:53

gaelicWizard mentioned this pull request Sep 9, 2021

Revamp command duration helper/plugin #1906

Merged

6 tasks

This was referenced Sep 18, 2021

DRAFT: All The Plugins #1950

Closed

Lib/log: linting and small improvements #1959

Merged

gaelicWizard mentioned this pull request Dec 31, 2021

Plugin/Java: quote path and provide useful error message #2006

Merged

6 tasks

gaelicWizard mentioned this pull request Jan 12, 2022

DRAFT: BATS: unofficial strict mode #2032

Closed

6 tasks

gaelicWizard and others added 12 commits March 4, 2022 13:04

install: use .bashrc and notify user

e888ddf

The logic to guess whether to use `.bash_profile` or `.bashrc` was buggy and wrong. Just use `.bashrc` and either automatically fill in a `.bash_profile`, or notify the user that they need to edit their `.bash_profile`.

install: cleanup

0853724

uninstall: cleanup

c3de63b

docs: fix references to ~/.bashrc

d55adc6

docs/installation: add to note about interactive/login shells

install: _bash-it-install-modify-profile()

4c5e87e

uninstall: //echo/printf

0485778

- Alsö, add implementation note at top.

uninstall: try to determine initialization file

68149f7

uninstall: TIL that `fgrep` is deprecated...

template: shfmt

52cd75b

template: shellcheck

affbce6

- and generally comment out useless varbls

lint: add lib to clean_files.txt

8a6debd

Revert "bash_it: source reloader.bash without arguments for the defau…

c09c050

…lt enabling" This reverts commit e05fa47. This reverts commit ee85367.

custom/example: shellcheck

d0e617a

c

seefood mentioned this pull request May 5, 2025

Rebased #1950 on current master: Cleanup all the plugins #2308

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`shellcheck` all core files#1917

`shellcheck` all core files#1917
gaelicWizard wants to merge 12 commits intoBash-it:masterfrom
gaelicWizard:shellcheck

gaelicWizard commented Aug 13, 2021 •

edited

Loading

Uh oh!

gaelicWizard commented Aug 13, 2021

Uh oh!

NoahGorny left a comment

Uh oh!

Uh oh!

davidpfarrell left a comment

Uh oh!

gaelicWizard commented Aug 15, 2021

Uh oh!

gaelicWizard commented Aug 15, 2021

Uh oh!

gaelicWizard commented Sep 9, 2021

Uh oh!

gaelicWizard commented Sep 20, 2021

Uh oh!

gaelicWizard commented Oct 10, 2021

Uh oh!

seefood commented Nov 10, 2024

Uh oh!

seefood commented Aug 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gaelicWizard commented Aug 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

Uh oh!

gaelicWizard commented Aug 13, 2021

Uh oh!

NoahGorny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

davidpfarrell left a comment

Choose a reason for hiding this comment

Uh oh!

gaelicWizard commented Aug 15, 2021

Uh oh!

gaelicWizard commented Aug 15, 2021

Uh oh!

gaelicWizard commented Sep 9, 2021

Uh oh!

gaelicWizard commented Sep 20, 2021

Uh oh!

gaelicWizard commented Oct 10, 2021

Uh oh!

seefood commented Nov 10, 2024

Uh oh!

seefood commented Aug 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gaelicWizard commented Aug 13, 2021 •

edited

Loading