Bug fix: Fix errorWidget on dart DDC (web) #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justus Fluegel <[email protected]>
JustusFluegel
changed the title
Signed-off-by: Justus Fluegel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix: The errorWidget would never be displayed when running using DDC (dart web) and the HttpGet option, which happens because the catch block currently never gets executed when using streams with
await foron dart DDC.As such this pr refactors the file to use a StreamController instead, re-implementing the original behavior.
Placeholder stays displayed even if a error response (e.g. 404) happened, when running using DDC
💥 Does this PR introduce a breaking change?
No, this is a pure bug fix.
🐛 Recommendations for testing
Maybe add a DDC test suite? idk
📝 Links to relevant issues/docs
async*method does not catch exceptions fromawait forin DDC dart-lang/sdk#47764🤔 Checklist before submitting