Updated bios versions comparison

BartoszCichecki · Jun 24, 2023 · 223c422 · 223c422
1 parent 0df7a14
commit 223c422
Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/LenovoLegionToolkit.Lib/Structs.cs b/LenovoLegionToolkit.Lib/Structs.cs
@@ -50,6 +50,17 @@ public bool IsHigherOrEqualThan(BiosVersion other)
         return Version >= other.Version;
     }
 
+    public bool IsLowerThan(BiosVersion other)
+    {
+        if (!Prefix.Equals(other.Prefix, StringComparison.InvariantCultureIgnoreCase))
+            return false;
+
+        if (Version is null || other.Version is null)
+            return true;
+
+        return Version < other.Version;
+    }
+
     public override string ToString() => $"{nameof(Prefix)}: {Prefix}, {nameof(Version)}: {Version}";
 }
 

diff --git a/LenovoLegionToolkit.Lib/Utils/Compatibility.cs b/LenovoLegionToolkit.Lib/Utils/Compatibility.cs
@@ -268,7 +268,7 @@ private static bool GetIsExcludedFromLenovoLighting(BiosVersion? biosVersion)
             new("GKCN", 54)
         };
 
-        return affectedBiosVersions.Any(bv => biosVersion?.IsHigherOrEqualThan(bv) ?? false);
+        return affectedBiosVersions.Any(bv => biosVersion?.IsLowerThan(bv) ?? false);
     }
 
     private static bool GetIsExcludedFromPanelLenovoLighting(string machineType, string model)