Adding Favicon to the webpage.

[nakul-py]

Description

Adding Favicon to the Cosmos Journeyer Webpage.
Fixes #293

[BarthPaleologue]

Did you even test your PR before opening it? Because if you had you would have noticed the favicon is not being displayed 🤔

It's just a simple path issue, so we should be able to merge once that's fixed (see details in comments).

[nakul-py]

As i have said before cannot build with webpack. I test it locally on vite haha.

[BarthPaleologue]

Ah I see, it explains ^^ Just so you know you can just run pnpm install in this branch to get back webpack so you can test your changes 👍

Then when you check out your vite branch, you just run pnpm install again to get back vite. You are not stuck with vite thanks to package.json being in git ;)

[nakul-py]

I tried but webpack gives errors

[BarthPaleologue]

What kind of Webpack errors @nakul-py ? Because reinstalling the packages when changing branch does work. If you are using npm instead of pnpm, you may want to perform npm ci instead of npm i because npm is quite the shitty package manager. That's one of the reasons I use pnpm

[BarthPaleologue]

Build CI does not work. Probably the path to the favicon is incorrect relative to the html file.

[nakul-py]

Build CI does not work. Probably the pass to the favicon is incorrect relative to the html file.

Ok i will do this later when project runs with vite.

[BarthPaleologue]

No problem, we are not in a hurry 👍