Swag labs tests #3

BarteKKmita · 2020-12-30T19:22:41Z

Ready to check

klubi · 2020-12-30T20:53:58Z

w 90% przypadków do repo nie powinno się commitować plików konfiguracyjnych konkretnego IDE.
Tobie sugeruję również tego nie robić i wywalić cały folder .idea.

klubi

Skorzystam z tego, że masz otwartego PR i dorzucę kilka komentarzy "ogólnych".

pliki z danymi/ pliki suite dla testNG powinny "żyć" w src/test/resources w odpowiedniej strukturze, żeby można było je łatwo znaleźć
unikaj przechowywania danych w plikach, których otwarcie wymaga konkretnego programu (w szczególności licencjonowanego jak produkty Microsoft) - np używaj csv zamiast xlsx, moim zdaniem yaml się całkiem dobrze sprawdza.
nie dodawaj plików exe do repo, zamiast tego dodaj README.md i opisz wymagania jakie należy spełnić przed uruchomieniem projektu
odseparuj testy od domeny (PageObjects, itd) najlepiej wrzuć pliki domenowe do src/main/java ułatwia to nawigację, ponieważ możesz wtedy PO trzymać w strukturze zbliżonej do "wyglądu" strony a testy zorganizować np wg funkcjonalności
przeprojektuj DriverModule, zamiast tworzyć na starcie dwa obiekty Drivera stwórz obiekt agnostyczny, np Browser, który w zależności od jakiegoś propertasa będzie pod getDriver zwracał instancję drivera, który ma zostać użyty do testów
na tym etapie podaruj sobie jakiekolwiek raportowanie, jak nabierzesz wprawy, to załatwisz raporty przy użyciu listenerów z testNG
nie znam za bardzo Guice, ale wydaje mi się że możesz dodać do swoich PO dwie rzeczy, które mega Ci ułatwią pracę:

wywalić konstruktor z każdego PO poprzez stworzenie klasy bazowej, która będzie używała metody adnotowanej @PostConstruct do wywołania PageFactory.initElements(this)
do powyższej klasy bazowej dodać metodę abstrakcyjną, którą każdy PO będzie musiał zaimplementować, metoda public boolean isLoaded() powinna zwracać informację o tym, czy dana strona została w pełni załadowana (czy wszystkie "ważne" elementy zostały załadowane", w połączeniu ze wspomnianym wcześniej obiektem Browser pozwoli Ci to na napisanie kilku bardzo pomocnych metod, którę będą np weryfikowały czy strona na którą przechodzisz jest załadowana zanim zaczniesz na niej wykonywać jakiekolwiek akcje.

build.gradle

src/test/java/com/learning/browsers/ChromeDriverGenerator.java

src/test/java/com/learning/pages/SwagLabsLoginPage.java

src/test/java/com/learning/SwagLabsLoginPageTest.java

build.gradle

BarteKKmita · 2021-01-04T19:36:45Z

src/main/java/com/learning/pages/PageBase.java

+public abstract class PageBase {
+  public PageBase(WebDriver driver) {
+    PageFactory.initElements(driver, this);
+  }


@PostConstruct is deprecated since Java 11.
What do you think about this solution?

It looks fine, I'm however not sure if there won't be any side effects.

it seems to not be deprecated, it was removed from sdk -> https://stackoverflow.com/a/55622713/2838206

But... it also looks like Guice does not support those annotations... so you'd have to figure out a different way to manage object lifecycle.

It looks fine, I'm however not sure if there won't be any side effects.

What do you mean? What are possible side effects?

But... it also looks like Guice does not support those annotations... so you'd have to figure out a different way to manage object lifecycle.

Could you provide me some article or give me tips how to do it?

Possible side effect would be an NPE thrown during object creation. I don't know if that's even possible, but just a thing to keep in mind.

I can't provide you a solution to that, I only read one stackoverflow thread that Guice does not "respect" those annotations. I have no real work experience with Guice, so I can't tell how it can be done.

I choose Guice for this one to learn sth new but I see that Spring is the best :)

src/main/java/com/learning/pages/google/GoogleSearchPage.java

src/main/java/com/learning/pages/swaglabs/SwagLabsInventory.java

BarteKKmita · 2021-01-04T19:41:43Z

src/test/java/com/learning/pages/swaglabs/SwagLabsLoginPageTest.java

+    String expectedErrorMessage = "Epic sadface: Username is required";
+    //When
+    driver.get(swagLabsLoginPage.getSwagLabsURL());
+    waitForPageToLoad();


Is this right usage of this method?

Not exactly. There are still few that would have to be implemented, but it could look like this

browser.open(SwagLabsLoginPage.class)

Browser could be an wrapper on driver, hiding driver completely.
Benefits? No selenium classes in tests... just page objects and browser.

I'll try to modify this branch to show you how this can be done.

src/main/java/com/learning/browsers/BrowserDriverGenerator.java

klubi

More incoming:)

gradle/wrapper/gradle-wrapper.properties

build.gradle

README.md

klubi · 2021-01-04T19:30:48Z

src/main/java/com/learning/browsers/BrowserDriverGenerator.java

+    propertiesReader = new PropertiesReader();
+  }
+
+  public WebDriver getDriver() {


This method will create new driver object each time it's called.
Instead create WebDriver field, and then:

if (driver == null) { //same if you already have, but instead return, assign driver to field } return driver;

This will allow you to create and manage only one instance of driver.

OK I get it. We make sure here to have Singleton. Let me implement it.
This will be a good exercise.

If method getDriver gets driver from the filed is it enough?
Are there situations where we want to run tests in multiple threads simultaneously?

src/main/java/com/learning/configuration/PropertiesReader.java

src/main/java/com/learning/pages/PageBase.java

src/main/java/com/learning/pages/swaglabs/SwagLabsInventory.java

src/main/java/com/learning/pages/PageBase.java

src/main/java/com/learning/browsers/BrowserDriverGenerator.java

klubi · 2021-01-04T20:51:16Z

src/test/java/com/learning/pages/google/FirstSeleniumTest.java

@@ -29,8 +42,8 @@ void shouldGoToJunit5WebPage() {
  @Test
  void shouldFindElementOnGoogleWebSite() {


Try implementing stuff, so the test looks like this:

void shouldFindElementOnGoogleWebSite() { googleSearchPage.open().search("Getting grip on it!"); }

(GoogleSearchPage would have to be injected by Guice)

This way:

googleSearchPage is responsible for knowing it's own URL

googleSearchPage holds logic responsible for waiting for page to load

googleSearchPage holds logic about search business process

test is more readable

test contains only business steps, high level ones, not all interactions with browser

no selenium in tests (no WebElements, no driver)

close to none setup

tearDown could also be removed if cleanup was moved to Browser class and PreDestroy method.

I have got close to requirements you provided but I think I need to see your Browser class to understand it.
But let's wait with that until I finish the rest.

build.gradle

BarteKKmita · 2021-01-06T17:50:40Z

build.gradle

+    implementation 'org.projectlombok:lombok:1.18.16'
+    annotationProcessor 'org.projectlombok:lombok:1.18.16'
+    testImplementation 'org.testng:testng:7.3.0'
+    implementation 'com.netflix.governator:governator:1.17.10'


I found governator which is library for managing lifecycle of objects for Guice but unfortunately I didn't manage to get it work with @PreDestroy. I will continue searching for solution later on.

src/main/java/com/learning/browsers/DriverModule.java

BarteKKmita · 2021-01-06T17:53:53Z

src/main/java/com/learning/browsers/WebDriverFactory.java

+
+  @PreDestroy
+  public void closeBrowser(){
+    webDriver.close();


This not working yet.

BarteKKmita · 2021-01-06T17:55:03Z

src/main/java/com/learning/pages/PageBase.java

+import org.openqa.selenium.support.PageFactory;
+
+public abstract class PageBase implements Closeable {
+


Added close method for closing resources. I will delete it when get @PreDestroy ready.

build.gradle

src/main/java/com/learning/browsers/DriverModule.java

src/main/java/com/learning/browsers/WebDriverFactory.java

src/main/java/com/learning/pages/google/GoogleSearchPage.java

src/main/java/com/learning/pages/swaglabs/SwagLabsLoginPage.java

klubi

Fix conflicts before merging.

BarteKKmita added 3 commits December 30, 2020 18:59

Repair closing driver

94d6dab

Add SwagLabs Login Page tests

00539e7

Switch to gradle

44931b8

klubi reviewed Dec 30, 2020

View reviewed changes

Refactor after review

8249833

BarteKKmita force-pushed the SwagLabsTests branch from 15f68e1 to 8249833 Compare January 4, 2021 19:25

Rename base class

cf6fe8f

BarteKKmita commented Jan 4, 2021

View reviewed changes

src/main/java/com/learning/pages/google/GoogleSearchPage.java Outdated Show resolved Hide resolved

BarteKKmita commented Jan 4, 2021

View reviewed changes

src/main/java/com/learning/pages/swaglabs/SwagLabsInventory.java Outdated Show resolved Hide resolved

BarteKKmita commented Jan 4, 2021

View reviewed changes

src/main/java/com/learning/browsers/BrowserDriverGenerator.java Outdated Show resolved Hide resolved

klubi reviewed Jan 4, 2021

View reviewed changes

src/main/java/com/learning/browsers/BrowserDriverGenerator.java Outdated Show resolved Hide resolved

src/main/java/com/learning/browsers/BrowserDriverGenerator.java Outdated Show resolved Hide resolved

klubi reviewed Jan 4, 2021

View reviewed changes

BarteKKmita marked this pull request as draft January 5, 2021 15:14

BarteKKmita added 9 commits January 5, 2021 17:47

Refactor after review

c59352c

Add modules for enabling dependency injection

1531036

Add class loader to PropertiesReader

b37a63c

Add WebDriverFactory

56f9d34

Add WebDriver as field to page objects

fc86e41

Refactor page objects

81f8c5a

Add closing webdriver

1943ecf

Add governator for @PreDestroy (solution not working)

9f75454

Refactoring

faf951e

BarteKKmita commented Jan 6, 2021

View reviewed changes

build.gradle Show resolved Hide resolved

BarteKKmita commented Jan 6, 2021

View reviewed changes

src/main/java/com/learning/browsers/DriverModule.java Show resolved Hide resolved

BarteKKmita commented Jan 6, 2021

View reviewed changes

klubi reviewed Jan 6, 2021

View reviewed changes

build.gradle Show resolved Hide resolved

src/main/java/com/learning/browsers/DriverModule.java Outdated Show resolved Hide resolved

klubi reviewed Jan 6, 2021

View reviewed changes

BarteKKmita added 4 commits January 8, 2021 19:09

Refactor after review

10f23bd

Change class name from WebDriverFactory to Browser

61071bf

Add Inventory Page

a527ca3

Refactor

3340ab7

BarteKKmita requested a review from klubi January 9, 2021 12:44

Correct finding web elements

b2d56df

BarteKKmita removed the request for review from klubi January 9, 2021 20:30

Delete unused code

0e0bd14

BarteKKmita requested a review from klubi January 10, 2021 10:06

BarteKKmita marked this pull request as ready for review January 10, 2021 10:31

klubi approved these changes Jan 10, 2021

View reviewed changes

BarteKKmita merged commit fd141e5 into master Jan 10, 2021

BarteKKmita deleted the SwagLabsTests branch January 14, 2021 08:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Swag labs tests #3

Swag labs tests #3

BarteKKmita commented Dec 30, 2020 •

edited

Loading

klubi commented Dec 30, 2020

klubi left a comment

BarteKKmita Jan 4, 2021

klubi Jan 4, 2021

klubi Jan 4, 2021 •

edited by BarteKKmita

Loading

BarteKKmita Jan 5, 2021

BarteKKmita Jan 5, 2021 •

edited

Loading

klubi Jan 6, 2021

BarteKKmita Jan 9, 2021

BarteKKmita Jan 4, 2021

klubi Jan 4, 2021

klubi left a comment

klubi Jan 4, 2021

BarteKKmita Jan 4, 2021

BarteKKmita Jan 9, 2021 •

edited

Loading

klubi Jan 4, 2021

BarteKKmita Jan 6, 2021

BarteKKmita Jan 6, 2021

BarteKKmita Jan 6, 2021

BarteKKmita Jan 6, 2021 •

edited

Loading

klubi left a comment

		@@ -29,8 +42,8 @@ void shouldGoToJunit5WebPage() {
		@Test
		void shouldFindElementOnGoogleWebSite() {

		import org.openqa.selenium.support.PageFactory;

		public abstract class PageBase implements Closeable {

Swag labs tests #3

Swag labs tests #3

Conversation

BarteKKmita commented Dec 30, 2020 • edited Loading

klubi commented Dec 30, 2020

klubi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

klubi Jan 4, 2021 • edited by BarteKKmita Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BarteKKmita Jan 5, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

klubi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BarteKKmita Jan 9, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BarteKKmita Jan 6, 2021 • edited Loading

Choose a reason for hiding this comment

klubi left a comment

Choose a reason for hiding this comment

BarteKKmita commented Dec 30, 2020 •

edited

Loading

klubi Jan 4, 2021 •

edited by BarteKKmita

Loading

BarteKKmita Jan 5, 2021 •

edited

Loading

BarteKKmita Jan 9, 2021 •

edited

Loading

BarteKKmita Jan 6, 2021 •

edited

Loading