Village bug fix #1026
Closed
Village bug fix #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettluskey
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Revert this file to what is on development
There was a problem hiding this comment.
This one seems to be part of the reason why the bug is ocurring. I changed it back how it was before October.
| @@ -106,7 +106,7 @@ public void StartPlayerSettlementEncounter(string partyId, string settlementId) | |||
| return; | |||
| } | |||
|
|
|||
| if (PlayerEncounter.Current is not null) return; | |||
| // if (PlayerEncounter.Current is not null) return; | |||
There was a problem hiding this comment.
does this need to be commented out?
There was a problem hiding this comment.
I tested it both ways and it also seems to be related to the bug.
| @@ -89,13 +89,13 @@ public void StartPlayerSettlementEncounter(string partyId, string settlementId) | |||
| { | |||
| if (objectManager.TryGetObject(partyId, out MobileParty mobileParty) == false) | |||
| { | |||
| Logger.Error("PartyId not found: {id}", partyId); | |||
| Logger.Error("PartyId not found: {id}", partyId); | |||
| /source/.cr/personal |
There was a problem hiding this comment.
Suggested change
| /source/.cr/personal | |
| **/.cr/** |
|
This was fixed by #1028 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
UI disappears when entering settlement and clicking "Wait here for some time"
What is the new behavior?
Resolves #818
Other information