Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sentry-sdk ^4.0 support #141

Merged
merged 7 commits into from
Apr 29, 2024

Conversation

WaylandAce
Copy link
Contributor

Closes #140

@bitgandtter
Copy link

@WaylandAce i need this update as well. i can help if you give me access to your fork/repo

@Baldinof
Copy link
Owner

@bitgandtter If you want to do another PR that use instanceof I will accept it

@WaylandAce
Copy link
Contributor Author

Applied suggestion.

@Baldinof
Copy link
Owner

It needs the use too

@bitgandtter
Copy link

bitgandtter commented Apr 29, 2024

@WaylandAce that needs to be applied to the listener as well

    public function onWorkerStop(WorkerStopEvent $event): void
    {
        $result = $this->hub->getClient()?->flush();
        if ($result instanceof GuzzleHttp\Promise\PromiseInterface) {
            $result->wait(false);
        }
    }

@bitgandtter
Copy link

@Baldinof can you review?

src/Integration/Sentry/SentryListener.php Outdated Show resolved Hide resolved
src/Integration/Sentry/SentryMiddleware.php Outdated Show resolved Hide resolved
@Baldinof Baldinof marked this pull request as ready for review April 29, 2024 20:34
@Baldinof Baldinof merged commit 5c4b631 into Baldinof:3.x Apr 29, 2024
9 checks passed
@Baldinof
Copy link
Owner

It's released as 3.1.1.

Thank you for the PR @WaylandAce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SentryMiddleware incompatibility with sentry ^4.0
3 participants