Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow RoadRunner 2023.x #110

Merged
merged 8 commits into from
May 17, 2023
Merged

Allow RoadRunner 2023.x #110

merged 8 commits into from
May 17, 2023

Conversation

Baldinof
Copy link
Owner

No description provided.

@AlexOstrovsky
Copy link

any luck with this?

@bitgandtter
Copy link

on a hurry for this to be released. any ETA?

@Baldinof
Copy link
Owner Author

Baldinof commented May 4, 2023

I'm doing my best to find the time for this.

Would it be ok for you if the minimum required Symfony version is 6.1?

Also the code here should work, if someone can give it a try in a real app, it would be nice.

@bitgandtter
Copy link

given that latest lts is 5.4 and that this feature is cutting edge at least IMO going for the next sf lts its good enough to 6.1 👍 on my end

@Baldinof Baldinof force-pushed the rr-2023 branch 3 times, most recently from 5e7540d to a9bb00c Compare May 4, 2023 21:17
@Baldinof Baldinof changed the base branch from 2.x to 3.x May 5, 2023 06:47
@AlexOstrovsky
Copy link

This PR will close my issue created earlier #109

@Baldinof
Copy link
Owner Author

Baldinof commented May 5, 2023

It's mostly good now if someone wants to give it a try.

You have to change your composer.json to point to this branch:

    "require": {
        ...
        "baldinof/roadrunner-bundle": "dev-rr-2023"
    },
    "repositories": [
        {
            "type": "git",
            "url": "https://github.com/baldinof/roadrunner-bundle"
        }
    ],

I just want to try some stuff with Doctrine before merging / releasing.

@bitgandtter
Copy link

I will gave it a try in the next days

@AlexOstrovsky
Copy link

I can try it next week

@AlexOstrovsky
Copy link

@Baldinof I tested it today and from my tests everything works with no problems with rr server 2023.1.2

@Baldinof Baldinof force-pushed the rr-2023 branch 3 times, most recently from 2940c20 to 96662fd Compare May 9, 2023 20:18
@Baldinof Baldinof marked this pull request as ready for review May 9, 2023 20:26
@Baldinof Baldinof force-pushed the rr-2023 branch 2 times, most recently from 2564667 to 70e75c4 Compare May 9, 2023 20:29
@Baldinof
Copy link
Owner Author

I just need to review the README and update the CHANGELOG and we should be good here :)

@AlexOstrovsky
Copy link

nice :) I have it on our testing environment and no problems popped up

@bitgandtter
Copy link

thanks so much @Baldinof to busy here and haven test it yet. maybe today. but reviewing the changes it does feel like it should work

@AlexOstrovsky
Copy link

@Baldinof when do you plan to merge and create a release?

@Baldinof Baldinof merged commit ffdda06 into 3.x May 17, 2023
@Baldinof
Copy link
Owner Author

I just released 3.0.0

I need to also upgrade the Symfony recipe and we should be good :)

@bitgandtter
Copy link

great work @Baldinof appreciated

@Baldinof Baldinof deleted the rr-2023 branch May 17, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants