Store sentence IDs in the correct named entity field #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, when named entities were created, their appearing sentence wasn’t being associated because we were trying to store its ID in `sentenceId` instead of `sentence_id`, the latter of which is the actual Postgres column name. However, by explicitly snake-casing at this point, we may be breaking some of the correct stitching of snake-cased Postgres fields to camelCased object attributes, and so we need to debug whether this is all associated together correctly by Sequelize and queryable by GraphQL. Affects #49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, when named entities were created, their appearing sentence wasn’t being associated because we were trying to store its ID in
sentenceIdinstead ofsentence_id, the latter of which is the actual Postgres column name.However, by explicitly snake-casing at this point, we may be breaking some of the correct stitching of snake-cased Postgres fields to camelCased object attributes, and so we need to debug whether this is all associated together correctly by Sequelize and queryable by GraphQL.
Closes #49