-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial full stack demonstration #21
Conversation
The organization of the directories is a little weird no matter how you slice it, but moving the public (static) assets outside of the client source is going to make it easier to set up hooks and also might be easier for new developers to understand what's going on. This will be more important before we start building out react components.
This project was apparently using deprecated babel stuff. This was causing trouble as I tried to set up react and parcel, so I'm upgrading it to the latest. Issue #13 Create react-based sentence rendering demo
This demo uses all sorts of crazy things. React and graphQL for one, but also with that comes stuff like bundlers (parcel). This commit installs a whole slew of new dependencies. Unfortunately this commit is part of Way Too Much At Once which means that it includes dependencies for a series of future commits ranging from backend all the way to frontend D3. Issue #13
I was a bad citizen and did not lint as I went along; this is a lint commit for the migrations
Again, this has some lint improvements. It also makes formal associations between some of the models which is needed later for our graphQL schema
GraphQL is a magical mechanism for exposing data without having to write restful APIs. This commit exposes the named entity and sentence objects via a graphQL api. Issue #13
My bad folks, I should have linted originally. This commit reorganizes everything in the opened captions worker and addresses the other linting issues. It should not have any impact on functionality, just the order that methids are listed.
5fe050a
to
69c4453
Compare
This works and marks a great prototype to iterate from. The installation instructions need updating but rather than force that upon this PR I'll handle it via #18. |
Update: well, partially works. Front page Keyword Counts are filling in: …but drilling into an entity detail nets blank boxes: Also, five console errors on the front page and three on the entity page. @slifty Do you want me to merge this in anyway and we can continue addressing this? I don't have any complaints about the larger architecture this PR scaffolds and prototypes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two overall thoughts:
- I can only get it partially working, see comment.
- This is fine for the demo/prototype stage, but I think soon we'll want to decouple the consumption/processing pipeline from the front end. I don't think, for instance, we'll always want to deploy them in tandem.
Neither of those should prevent merging this in, as it's good enough to start fixing.
Thank you -- I'm going to try to replicate locally and fix the PR before we merge! Note that not all elements work (e.g. Recent Transcript / Recent Entities) but the drilldowns should |
Ping me if you want to pair on it. Could be something env-specific that's not rearing its head more obviously. |
SORRY accidental close! |
This commit is way too large, but there isn't a huge amount of value in breaking it up at this point... I always say that. Anyway, this contains a very basic interface to show off the talking point tracker functionality as it stands. It even includes a VERY IMPRESSIVE logo which is safe to consider 100% final. This is written in react, and leverages graphQL to load in the data itself. Issue #13
69c4453
to
75e2f3c
Compare
All righty -- I had added a bunch of propType details without realizing that null is not a valid value for required types. There were some other issues related to iterated DOM elements that needed keys. This should all be fixed up now; I'm going to merge this so we can keep on going! |
This is not beautiful, but it does show off basic functionality. This is the PR for the demo that was made in early December, but the code is a bit more organized and now properly linted. Here are some screen shots of what it does.
Base page, showing frequency counts for "all time" (note that all time here was about a two hour window)
If you click a bar, you go to detail view that looks something like this
The interfaces are in react, they pull data from a graphQL api.
This resolves #13