Feat/db #66
Open
Feat/db #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bad3r
force-pushed
the
master
branch
2 times, most recently
from
4c12d03
to
6244543
Compare
Bad3r
force-pushed
the
master
branch
4 times, most recently
from
9a2e078
to
458ac81
Compare
tiensonqin
force-pushed
the
feat/db
branch
2 times, most recently
from
ec41c85
to
b66a3b8
Compare
Because some classes depend on others.
Make useful new tag pages easier to discover
or any commands using dialog-select!. Modal used to display search commands didn't close after selecting an item
Don't overload 'Card' to mean multiple things. Also improved migration docstrings
Also remove unnecessary hack for property.view/type
Refactor: dsl query
Throwing errors on unsupported filters for these makes it seem like we support it when we don't. Better to be explicit. Also tweak related tests so that file graph filters only run for file graphs
instead of deleted page-property rules
for db graphs. Also tweaked example graph so blocks and pages have same property values in order to QA property rules like this
It's helpful to validate more about these heavily properties beyond them just being integers. Follow up to #11565
classes haven't had :block/schema for awhile
from #11565. Also stop logging errors for valid between queries and deleted unused test code
File graphs fail on it b/c of d/datoms lookup on db graph properties
Fixes db graphs being invalid and some of logseq/db-test#7 (comment)
when they have different parents. Addressing 2nd section in logseq/db-test#7 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.