Fix leaking buckets in integration tests #829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlesniewski-reef
force-pushed
the
parallel-integration-tests-fix
branch
from
7eb3ba7
to
fa216a8
Compare
ppolewicz
reviewed
Nov 18, 2022
test/integration/helpers.py
Outdated
Comment on lines
240
to
246
| @property | ||
| def success(self): | ||
| return self.status == 0 | ||
|
|
||
| @property | ||
| def failure(self): | ||
| return not self.success |
There was a problem hiding this comment.
is_success
is_failure, annotate type to boolean
test/integration/helpers.py
Outdated
| @@ -248,11 +231,30 @@ def read_from(self, f): | |||
| self.string = str(e) | |||
|
|
|||
|
|
|||
| @dataclasses.dataclass | |||
There was a problem hiding this comment.
also please add a note in the comment to add slots=True when dropping 3.9
There was a problem hiding this comment.
Moved it to a NamedTuple, it's both like slots and frozen.
test/integration/helpers.py
Outdated
|
|
||
| def run(self, args, additional_env: Optional[dict] = None) -> CommandResult: | ||
| if args: | ||
| if args[0] == 'create-bucket': |
There was a problem hiding this comment.
we support create_bucket too, legacy syntax. Replace _ with - in args[0] before comparison
test/integration/helpers.py
Outdated
| if args: | ||
| if args[0] == 'create-bucket': | ||
| raise ValueError(f'use {type(self).__name__}.create_bucket instead') | ||
| elif args[0] == 'delete-bucket': |
mlesniewski-reef
force-pushed
the
parallel-integration-tests-fix
branch
from
fa216a8
to
8f4f431
Compare
* master: (54 commits) Changelog adjustments Changelog updated Removed wrongly merged pyinstaller options PR fixes PR fixes - comment clarification Fix for tests in Python 3.7 Linter fix Added a simple test to check whether incrementalMode doesn't break anything PR fixes Linter fix Fix for unit-tests after 1.19.0 release of b2sdk Ensuring that changelog is properly added to the release Simplified digest, using name property of a hashlib structure Cleaner iteration over created hash structures Removed limitation on file of the files from which the digest is calculated Ensuring that CI-only B2 installation also is silent on CI Changes to the test case (supporting old and new reponse) reverted Changelog updated Providing system-under-test executable from bundle to CI Hashes of releases added ...
Also limited number of parallel tests in CI
|
Replaced by improvements made in #946 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bucket clean ups during integration test teardown. This is achieved by tracking created and deleted buckets (both via the API and the CLI) and deleting everything which might have not been deleted automatically after each test case.
Additionally, a
create_test_bucketfixture factory has been introduced, which allows for easy bucket creation. This is useful especially in tests, which need to create more than one bucket. Thebucket_namefixture is still available and in use in simpler test cases.Some buckets are still created using the
create-bucketCLI command -- this was left this way on purpose, to ensure the command and its switches are covered by tests too.The PR also re-enables parallel integration test execution (
pytest-xdist) as it should work correctly now. It also introduces a change in the CI workflow config to only allow running one workflow at a time.This should be reviewed together with corresponding changes in the SDK: Backblaze/b2-sdk-python#355