DO NOT MERGE!! [WF-2017] Allow overriding translations from parent components or app using pro… #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcorral
changed the title
tcorral
changed the title
tcorral
changed the title
RAJESH-GN
reviewed
Jan 28, 2025
RAJESH-GN
reviewed
Jan 29, 2025
apps/golden-sample-app/src/app/user-accounts/user-accounts-view/user-accounts-view.component.ts
Outdated
Show resolved
Hide resolved
RAJESH-GN
reviewed
Jan 29, 2025
.../feature/src/lib/components/ach-positive-pay-journey/ach-positive-pay-journey.component.html
Outdated
Show resolved
Hide resolved
… possibility to add more if needed
…default translations
RAJESH-GN
previously approved these changes
Jan 31, 2025
...on-details-view/src/lib/transactions-journey-feature-transaction-details-view.component.html
Outdated
Show resolved
Hide resolved
RAJESH-GN
reviewed
Feb 4, 2025
| 'main.entitlements-test-nested-groups.text': string; | ||
| 'main.entitlements-test-using-not-operators-on-groups.text': string; | ||
| 'main.entitlements-test-using-multiple-not-operators-on-groups.text': string; | ||
| [key: string]: string; |
There was a problem hiding this comment.
I would avoid this one if we have typed the whole translations @tcorral
| public layoutService: LayoutService, | ||
| @Inject(APP_TRANSLATIONS) | ||
| private readonly overridingTranslations: Partial<AppTranslations>, |
There was a problem hiding this comment.
why should this be Partial please try to have this as a last resource to have Partials as it might break so many things?
| 'user-accounts.view-transactions': string; | ||
| 'user-accounts.add-favorites': string; | ||
| 'user-accounts.remove-favorites': string; | ||
| [key: string]: string; |
There was a problem hiding this comment.
Same here we should not allow this if we have types written
| @@ -1 +1,5 @@ | |||
| export { TextFilterComponent } from './lib/components/text-filter/text-filter.component'; | |||
| export { | |||
There was a problem hiding this comment.
import of the actual translation is missing
There was a problem hiding this comment.
there are couple of index.ts files where the index files are missing the export of actual translations can u please update the imports of those files please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE!!!