Skip to content

Fix iOS camera crash: update BabylonNative to latest#715

Merged
CedricGuillemet merged 2 commits intoBabylonJS:masterfrom
CedricGuillemet:fixiOSCamera
Mar 27, 2026
Merged

Fix iOS camera crash: update BabylonNative to latest#715
CedricGuillemet merged 2 commits intoBabylonJS:masterfrom
CedricGuillemet:fixiOSCamera

Conversation

@CedricGuillemet
Copy link
Copy Markdown
Collaborator

Description

Updates the BabylonNative commit reference in gulpfile.js from 3ccba7a to 887a044 to pick up critical fixes.

Key Fix

iOS CameraDevice null dereference (BabylonJS/BabylonNative#1649): The error variable passed to newRenderPipelineStateWithDescriptor may be nil even when the call fails. The previous code would dereference this nil pointer when building the error message string, causing a crash. The fix adds a nil guard before accessing the error object.

Other changes included

Changes

  • Package/gulpfile.js: Updated COMMIT_ID to 887a0446c2ce5d379d931d802071cf6f9e008c6a

Update BabylonNative commit reference to pick up the fix for null
dereference on error in iOS CameraDevice (BabylonJS/BabylonNative#1649).

The error variable passed to newRenderPipelineStateWithDescriptor may
be nil even when the call fails. The new commit guards against
dereferencing nil when building the error message string.

Also includes:
- MSVC /MP multiprocessor build flag (BabylonJS/BabylonNative#1644)
- bgfx update for x86 crash fix (BabylonJS/BabylonNative#1643)
- Crash dump collection on all CI platforms (BabylonJS/BabylonNative#1641)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 26, 2026 17:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pinned BabylonNative source revision used by the packaging workflow to pick up upstream fixes (notably the iOS CameraDevice crash fix described in the PR).

Changes:

  • Bump BabylonNative commit reference used for ZIP download/extraction in the packaging gulpfile.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@CedricGuillemet CedricGuillemet enabled auto-merge (squash) March 26, 2026 17:31
@CedricGuillemet CedricGuillemet merged commit 15ae894 into BabylonJS:master Mar 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants