Skip to content

Fixed race condition when passing data to bgfx. Issue #1398 #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bkaradzic-microsoft wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed race condition when passing data to bgfx. Issue #1398 #1628

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f89234d
Fixed race condition when passing data to bgfx.
bkaradzic Mar 12, 2026
34f0171
Image is array, not single image container.
bkaradzic Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Plugins/NativeEngine/Source/NativeEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ namespace Babylon
texture->Create2D(static_cast<uint16_t>(image->m_width), static_cast<uint16_t>(image->m_height), (image->m_numMips > 1), 1, Cast(image->m_format), flags);
}

for (uint8_t mip = 0; mip < image->m_numMips; ++mip)
for (uint8_t mip = 0, numMips = image->m_numMips; mip < numMips; ++mip)
Copy link
Contributor

@bghgary bghgary Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this fixes the problem completely. We are still using image inside the for loop. At the minimum, the image->m_numMips usage needs to be replaced with numMips, but I'm not sure that's good enough.

Ditto for the other function.

Copy link
Contributor Author

@bkaradzic-microsoft bkaradzic-microsoft Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is the last loop when it needs to exit was touching image, which might be released from the other thread. Alternative is just to do bgfx::copy and not deal with bgfx::makeRef / release.

Copy link
Contributor

@bghgary bghgary Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's discuss offline

{
bimg::ImageMip imageMip{};
if (bimg::imageGetRawData(*image, 0, mip, image->m_data, image->m_size, imageMip))
Expand Down Expand Up @@ -387,7 +387,7 @@ namespace Babylon
for (uint8_t side = 0; side < 6; ++side)
{
bimg::ImageContainer* image{images[side]};
for (uint8_t mip = 0; mip < image->m_numMips; ++mip)
for (uint8_t mip = 0, numMips = image->m_numMips; mip < numMips; ++mip)
{
bimg::ImageMip imageMip{};
if (bimg::imageGetRawData(*image, 0, mip, image->m_data, image->m_size, imageMip))
Expand Down
Loading