-
Notifications
You must be signed in to change notification settings - Fork 153
Updated Linux building instructions. #1624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bkaradzic-microsoft
wants to merge
4
commits into
master
Choose a base branch
from
update-docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1554ccb
Updated Linux building instructions.
bkaradzic c1e3237
Fix misleading "Clang-9 toolchain" label in Linux build instructions …
Copilot 0b71f3b
Fix inconsistent apt usage and duplicate JSC package in Linux build i…
Copilot 07ad0fa
Fix invalid CMake command in Linux building instructions (#1625)
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -276,10 +276,10 @@ _Follow the steps from [All Development Platforms](#all-development-platforms) b | |||||
|
|
||||||
| The minimal requirement target is an OpenGL 3.3 compatible GPU. Clang 9+ or GCC 9+ are required for building. | ||||||
|
|
||||||
| First step is to install packages mandatory for building. For example, with Clang-9 toolchain: | ||||||
| First step is to install packages mandatory for building. For example, with a GCC toolchain: | ||||||
|
|
||||||
| ``` | ||||||
| sudo apt-get install libgl1-mesa-dev libcurl4-openssl-dev clang-9 libc++-9-dev libc++abi-9-dev lld-9 ninja-build | ||||||
| sudo apt-get install libgl1-mesa-dev x11proto-core-dev libx11-dev libcurl4-openssl-dev g++ cmake ninja-build npm | ||||||
| ``` | ||||||
|
|
||||||
| Depending on the JavaScript engine you want to use, you will have to install the package accordingly: | ||||||
|
|
@@ -295,7 +295,7 @@ sudo apt-get install libjavascriptcoregtk-4.1-dev | |||||
| Then, run cmake targetting a Ninja make file: | ||||||
|
|
||||||
| ``` | ||||||
| cmake -G Ninja -D JAVASCRIPTCORE_LIBRARY=/usr/lib/x86_64-linux-gnu/libjavascriptcoregtk-4.1.so -D NAPI_JAVASCRIPT_ENGINE=JavaScriptCore | ||||||
| cmake -B build/linux -G Ninja -D NAPI_JAVASCRIPT_ENGINE=JavaScriptCore | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
JavaScriptCore is also the default now. |
||||||
| ``` | ||||||
|
|
||||||
| ### V8 | ||||||
|
|
@@ -309,13 +309,13 @@ sudo apt-get install libv8-dev | |||||
| Then, run cmake targetting a Ninja make file: | ||||||
|
|
||||||
| ``` | ||||||
| cmake -G Ninja -D NAPI_JAVASCRIPT_ENGINE=V8 | ||||||
| cmake -B build/linux -G Ninja -D NAPI_JAVASCRIPT_ENGINE=V8 | ||||||
| ``` | ||||||
|
|
||||||
| And finally, for any JavaScript engine, run a build: | ||||||
|
|
||||||
| ``` | ||||||
| ninja | ||||||
| cmake --build build/linux | ||||||
| ``` | ||||||
|
|
||||||
| You can switch compiler between GCC and Clang by defining shell variables. | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should add
npmhere. Depending on how people usenpm, it may be installed differently. Same goes forcmake. They are already requirements listed in theAll Development Platformssection.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, why switch from CLang to GCC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since clang is not really required and GCC might be already installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole command line gets you into the state where you can build just build. If cmake or npm is not there, something might fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but many people don't install cmake or npm using apt, so this may cause problems for them.