Typescript #1554
Typescript #1554
Conversation
|
I think this is a step in the right direction for sure, but I feel like moving to esm packages instead of umd packages is a big part of what would be added value. But maybe I'm thinking too much about specifically having a test app for the Viewer. I suppose I could have a totally separate .ts entry point for that though, and have that one depend on esm packages. |
|
@ryantrem we can talk offline about that. Quickly, I've faced some blockers like:
|
| "${CMAKE_CURRENT_LIST_DIR}/iOS/Base.lproj/Main.storyboard" | ||
| "${CMAKE_CURRENT_LIST_DIR}/iOS/Base.lproj/LaunchScreen.storyboard") | ||
| set(RESOURCE_FILES ${STORYBOARD} ${SCRIPTS}) | ||
| set(RESOURCE_FILES ${STORYBOARD} ${SCRIPTS} ${JS_SCRIPTS}) |
There was a problem hiding this comment.
Do we now have both the .ts and .js files as resources? Is that what we want?
There was a problem hiding this comment.
I have no strong opnion on that. It was handy to quickly open produced .js thanks to project hierarchy. Also to be consistent with babylon.max.js copy.
There was a problem hiding this comment.
I'm more worried about it being added to the final running package. The .ts are source files, so they don't belong there, right? Or maybe I missed something.
| "title": "Multi cameras and output render target", | ||
| "renderCount": 2, | ||
| "playgroundId": "#BCYE7J#31", | ||
| "playgroundId": "#BCYE7J#46", |
There was a problem hiding this comment.
Is this related to the TypeScript changes?
There was a problem hiding this comment.
Yes. "Use strict" now makes an assignation to a read only value trigger an exception. Assignation fixed in the PG.
There was a problem hiding this comment.
I see. This test is from the JS side, so maybe we should update the config.json in Babylon.js also?
|
|
||
| if (text) { | ||
| const Writer = BABYLON.MeshWriter(scene, { scale: 1.0, defaultFont: "Arial" }); | ||
| // @ts-ignore |
There was a problem hiding this comment.
No definition for MeshWriter.
There was a problem hiding this comment.
Maybe put a comment after // @ts-ignore to explain why.
@CedricGuillemet Please include me when we talk about this offline. |
4 participants
Uh oh!
There was an error while loading. Please reload this page.