Fix FlowGraphCoordinator not adding itself to SceneCoordinators list#18128
Fix FlowGraphCoordinator not adding itself to SceneCoordinators list#18128deltakosh merged 1 commit intoBabylonJS:masterfrom
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18128/merge/index.html#WGZLGJ#4600 Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves): https://playground.babylonjs.com/?snapshot=refs/pull/18128/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/18128/merge#BCU1XR#0 If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools. |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
RaananW
left a comment
RaananW
left a comment
There was a problem hiding this comment.
Very valid, but it is not being used anywhere in the code. I am trying to understand if this is a bug fix from experience, and where do you use the SceneCoordinators map.
|
Just ran into it while debugging some FlowGraphCoordinator issues on my side. Not actually using it but thought might as well fix. |
RaananW
left a comment
RaananW
left a comment
There was a problem hiding this comment.
Clearly a bug, thank you very much. Just FYI - a lot of changes are coming to the flow graph and the flow graph coordinator. No breaking changes of course, but we are expanding and fixing bugs under the hood.
@RaananW cool to hear this. Any way I could get a peek into that branch / conversation? |
5 participants
FlowGraphCoordinator: SceneCoordinators weren't persisting. The constructor created a new array via
?? []but never called .set() on the Map, so SceneCoordinators.get(scene) always returned undefined. Any tooling using this API could never discover running coordinators. Fixed by initializing and storing the array on first use.