[Fix] Gaussian splatting GPU picker exclude inactive parts#18090
[Fix] Gaussian splatting GPU picker exclude inactive parts#18090spsDrop wants to merge 3 commits intoBabylonJS:masterfrom
Conversation
…and non-pickable parts
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18090/merge/index.html#WGZLGJ#4600 Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves): https://playground.babylonjs.com/?snapshot=refs/pull/18090/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/18090/merge#BCU1XR#0 If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools. |
| varying float vPartIndex; | ||
| #if IS_COMPOUND | ||
| uniform vec3 partPickingColors[${this._maxPartCount}]; | ||
| uniform float partActive[${this._maxPartCount}]; |
There was a problem hiding this comment.
You can group both uniform in a single vec4. Some devices have a very limited number of possible uniforms. Also, this will need to be updated for worst case scenario :
There was a problem hiding this comment.
Or, is it possible to merge usage of partActive and partVisibility and have a single uniform for both?
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
@spsDrop I'm testing this PG : https://playground.babylonjs.com/?snapshot=refs/pull/18090/merge#3LNCE6#36 and I can't pick any GS. Am I missing something? |
|
@CedricGuillemet Looks like I had committed a version with the wrong shader code. It's fixed now I also caught a bug where non-compound meshes wouldn't be excluded based on visibility or isPickable, and fixed it. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Reviewer - this PR has made changes to the build configuration file. This build will release a new package on npm If that was unintentional please make sure to revert those changes or close this PR. |
CedricGuillemet
left a comment
CedricGuillemet
left a comment
There was a problem hiding this comment.
LGTM! PG works fine
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
@spsDrop ready to merge if you're done. |
3 participants
Gaussian splatting GPU picker compound meshes hide non-visible and non-pickable parts