-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small changes to jest, including the recommended jest extension #15809
base: master
Are you sure you want to change the base?
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15809/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/15809/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/15809/merge#BCU1XR#0 |
Visualization tests for WebGPU (Experimental) |
WebGL2 visualization test reporter: |
Extension acts weird after a while, testing. |
@@ -6,6 +6,7 @@ | |||
"webhint.vscode-webhint", | |||
"IronGeek.vscode-env", | |||
"firsttris.vscode-jest-runner", | |||
"ms-playwright.playwright" | |||
"ms-playwright.playwright", | |||
"orta.vscode-jest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is another option for running jest tests, right? Seems like we should pick between this one and the existing "firsttris.vscode-jest-runner" on line 8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this extension to be much (MUCH) better. I didn't even notice the other one is there. I continue testing it locally, will see what i come up with.
LGTM but really tested quickly :-) |
This mades changes to the jest configuration to remove a seprecation warning.
I also include the jest extension in the recommendations for this repo to allow quick testing using vscode.