Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes to jest, including the recommended jest extension #15809

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Nov 13, 2024

This mades changes to the jest configuration to remove a seprecation warning.

I also include the jest extension in the recommendations for this repo to allow quick testing using vscode.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 13, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 13, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 13, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 13, 2024

@RaananW RaananW marked this pull request as draft November 13, 2024 14:34
@RaananW
Copy link
Member Author

RaananW commented Nov 13, 2024

Extension acts weird after a while, testing.

@@ -6,6 +6,7 @@
"webhint.vscode-webhint",
"IronGeek.vscode-env",
"firsttris.vscode-jest-runner",
"ms-playwright.playwright"
"ms-playwright.playwright",
"orta.vscode-jest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another option for running jest tests, right? Seems like we should pick between this one and the existing "firsttris.vscode-jest-runner" on line 8?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this extension to be much (MUCH) better. I didn't even notice the other one is there. I continue testing it locally, will see what i come up with.

@RaananW
Copy link
Member Author

RaananW commented Nov 14, 2024

The two extensions actually "merge" nicely. The new one adds the following:

image

It also adds the tests in the test tab:

image

The older one's nicest feature is the "Run | Debug" buttons on top of each test:

image

Other than that it is not very visible.

I have them both running right now. They don't collide and play nicely with one another. If anyone wants to experiment with the new one and give an opinion - let me know :-)

@sebavan
Copy link
Member

sebavan commented Nov 14, 2024

LGTM but really tested quickly :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants