Lots of typo fixes #359
Lots of typo fixes #359
Conversation
There was a problem hiding this comment.
Most of this seems fine. The AUTHORS file needs the encoding fixed so it doesn't break names.
For any msgid changes in the data/l10n/ files, you'd want to sure that the strings in the game code are changed as well. For instance, you changed "recieved" to "received", but src/bzadmin/ServerLink.cxx and src/bzflag/ServerLink.cxx still have "bytes recieved".
I'm not sure if we should care about fixing typos shtool since it is a third-party file and it isn't one that anyone every looks at anyway.
I'd need to check a bit more if we can just get rid of misc/libtool.m4.
| @@ -196,7 +196,7 @@ int main(int argc, char *argv[]) | |||
| echo "*** If you have an old version installed, it is best to remove it, although" | |||
| echo "*** you may also be able to get things to work by modifying LD_LIBRARY_PATH"], | |||
| [ echo "*** The test program failed to compile or link. See the file config.log for the" | |||
| echo "*** exact error that occured. This usually means SDL was incorrectly installed" | |||
| echo "*** exact error that occurred. This usually means SDL was incorrectly installed" | |||
There was a problem hiding this comment.
This typo is from upstream SDL repository that we pulled this file from. Fixing it upstream would be better, and then we can fix it here by pulling it from upstream.
There was a problem hiding this comment.
Changes suggested and merged. I'm not sure how to pull from upstream, so should I just leave it like this?
| @@ -267,7 +267,7 @@ eval `echo h.$opt_spec |\ | |||
| eval `echo h:help,$opt_alias |\ | |||
| sed -e 's/-/_/g' -e 's/\([a-zA-Z0-9]\):\([^,]*\),*/opt_ALIAS_\2=\1;/g'` | |||
|
|
|||
| # interate over argument line | |||
| # iterate over argument line | |||
There was a problem hiding this comment.
This is a generated file from an upstream project called GNU shtool. We're using an older version, but the latest release still has these typos. Given that the newest release is from 2008, I don't imagine this will get fixed upstream.
There was a problem hiding this comment.
So would you like it to be fixed here or stay consistent with the other release?
This comment was marked as outdated.
This comment was marked as outdated.
|
Will reopen as a new PR later. EDIT: #362. |
You might want to squash and merge.
Automated processes found most of these errors.