Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/564 bug trains randomly stop/uninitialized trains are not added to reservations #591

Merged
merged 14 commits into from
Jul 26, 2023
Merged

Feature/564 bug trains randomly stop/uninitialized trains are not added to reservations #591

merged 14 commits into from
Jul 26, 2023

Conversation

Lietze
Copy link
Collaborator

@Lietze Lietze commented Jul 24, 2023 •
edited
Loading

Fixes #564

Description (what might a PO or reviewer want to know?)

PR checklist

  • Acceptance criteria fulfilled
  • Additional features are tested
  • Docs (code, wiki & diagrams) updated
  • Breaking changes anounced
  • Added classes that inherit from BaseModel to src.constants.tables
  • Dev-branch has been merged into local branch to resolve conflicts
  • Tests and linter have passed AFTER local merge
  • Another dev reviewed and approved

@Lietze Lietze linked an issue Jul 24, 2023 that may be closed by this pull request
Bug: Trains randomly stop #587
Open
@Lietze Lietze mentioned this pull request Jul 24, 2023
Closed
@LucasDerReisende
Copy link
Collaborator

With this standard scenario, the trains will still stop for me

@Lietze Lietze removed a link to an issue Jul 25, 2023
Bug: Trains randomly stop #587
Open
@Lietze Lietze changed the title Bug/587 bug trains randomly stop Feature/564 bug trains randomly stop/uninitialized trains are not added to reservations Jul 25, 2023
LucasDerReisende
LucasDerReisende approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@LucasDerReisende LucasDerReisende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Lietze Lietze merged commit 1fc6245 into dev Jul 26, 2023
10 checks passed
@Lietze Lietze deleted the bug/587-bug-trains-randomly-stop branch July 26, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasDerReisende LucasDerReisende LucasDerReisende approved these changes

Assignees

@Lietze Lietze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UninitializedTrain is added to reservation queues
2 participants
@Lietze @LucasDerReisende