Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add interlocking initialization #329

Merged
merged 34 commits into from
Apr 20, 2023
Merged

add interlocking initialization #329

merged 34 commits into from
Apr 20, 2023

Conversation

Lietze
Copy link
Collaborator

@Lietze Lietze commented Apr 17, 2023 •
edited
Loading

Fixes #289

Description (what might a PO or reviewer want to know?)

PR checklist

  • Acceptance criteria fulfilled
  • Additional features are tested
  • Docs (code, wiki & diagrams) updated
  • Breaking changes anounced
  • Added classes that inherit from BaseModel to src.constants.tables
  • Dev-branch has been merged into local branch to resolve conflicts
  • Tests and linter have passed AFTER local merge
  • Another dev reviewed and approved

@Lietze Lietze changed the title added data directory add interlocking initialization Apr 17, 2023
@Lietze
add PlanPro file
3b63222
@Lietze
update toml to refrence git fork
18aa367
@Lietze
fix lint and add __init__.py
1e0c66c
@Lietze
add sumo_config_helper
dcb1cb1
@Lietze
restructure directories
f181382
@Lietze
changed cords to schwarze Pumpe
8819240
@Lietze
use refactored version of yaramo
0775ae8
@Lietze
change configs so a new planpro would be generated
08d0477
@Lietze
fix lint
3bf2421
@Lietze
add start_interlocking
e8e4f4e
@Lietze
Add test, that runs if not for faults in yaramo
4cecdaa
@Lietze
added another model
f6adf53
@Lietze
added Signal Generator
ab5c704
@Lietze
the points are fixed
03036dc
@Lietze
fix lint
55a965d
@Lietze
add Platform import
b3efd8b
@Lietze
add new version of data
76c25c4
@Lietze
fix lint
e6688db
@Lietze
realy fix lint
5fa83f2
@Lietze
fix typehints
e0e3506
@Lietze
Merge branch 'dev' into feature/289-add-initialization-of-interlocking
d512c7b
@Lietze
add right poetry.lock
833d37b
@Lietze
changed path acording to project dir structure
0e2d564
@Lietze
change paths again
21b418d
@Lietze
move the example
82d8e79
@Lietze Lietze marked this pull request as ready for review April 20, 2023 11:47
antonykamp
antonykamp reviewed Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@antonykamp antonykamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR 👍 Maybe we should consider adding some documentation about the examples in the data folder. What do you think about a new wiki entry or a README file in the /data folder?

src/interlocking_component/route_controller.py Outdated Show resolved Hide resolved
src/wrapper/communicator.py Outdated Show resolved Hide resolved
tests/wrapper/test_simulation_objects.py Outdated Show resolved Hide resolved
tests/wrapper/test_simulation_object_updating_component.py Outdated Show resolved Hide resolved
tests/interlocking_component/test_route_controller.py Outdated Show resolved Hide resolved
src/interlocking_component/route_controller.py Show resolved Hide resolved
@Lietze Lietze requested a review from antonykamp April 20, 2023 13:32
antonykamp
antonykamp approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@antonykamp antonykamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍 Keep going!

@Lietze
Copy link
Collaborator Author

Lietze commented Apr 20, 2023

I added a wiki page for data, but I'm not realy happy with it. Do you have ideas?

@antonykamp
Copy link
Collaborator

I added a wiki page for data, but I'm not realy happy with it. Do you have ideas?

I like it 🙃 Maybe you could add some sentences about the existing examples too?

@Lietze
Copy link
Collaborator Author

Lietze commented Apr 20, 2023

I added a wiki page for data, but I'm not realy happy with it. Do you have ideas?

I like it 🙃 Maybe you could add some sentences about the existing examples too?

I don't feel like that would make a lot of sense, because they are subject to change. This will be a good idea once we have a good network with routes.

@Lietze Lietze merged commit 4da78b7 into dev Apr 20, 2023
@Lietze Lietze deleted the feature/289-add-initialization-of-interlocking branch April 20, 2023 14:31
@antonykamp
Copy link
Collaborator

I don't feel like that would make a lot of sense, because they are subject to change. This will be a good idea once we have a good network with routes.

Sound reasonable 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonykamp antonykamp antonykamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add initialization of the interlocking
2 participants
@Lietze @antonykamp