-
Notifications
You must be signed in to change notification settings - Fork 492
[ci][linux] build client and manager for arm64 #6587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7333340
to
00926d9
Compare
00926d9
to
aa727f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the Linux build system to support building BOINC client and manager components for the arm64 architecture using vcpkg, extending the existing CI infrastructure.
- Refactors existing vcpkg update scripts to accept architecture triplets as parameters
- Adds new build configurations for arm64 client and manager builds
- Updates CI workflow and deployment scripts to include arm64 variants
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
linux/update_vcpkg_libs.sh | Added copyright header and parameterized triplet support |
linux/update_vcpkg_client.sh | Added copyright header and parameterized triplet support |
linux/update_vcpkg_apps.sh | Added copyright header and parameterized triplet support |
linux/arm64/update_vcpkg_libs.sh | Removed duplicate arm64-specific script |
linux/arm64/update_vcpkg_apps.sh | Removed duplicate arm64-specific script |
linux/arm64/ci_configure_manager.sh | New arm64 manager build configuration script |
linux/arm64/ci_configure_libs.sh | Updated to use parameterized vcpkg script |
linux/arm64/ci_configure_client.sh | New arm64 client build configuration script |
linux/arm64/ci_configure_apps.sh | Updated to use parameterized vcpkg script with copyright header |
deploy/prepare_deployment.py | Added arm64 deployment functions and reorganized build types |
.github/workflows/linux.yml | Added arm64 client/manager build jobs and improved build parallelization |
Comments suppressed due to low confidence (1)
linux/arm64/ci_configure_client.sh:1
- Incorrect script reference. This should be
linux/update_vcpkg_client.sh $TRIPLET
since this is configuring the client, not the manager.
#!/bin/sh
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
linux/update_vcpkg_libs.sh
Outdated
# along with BOINC. If not, see <http://www.gnu.org/licenses/>. | ||
# | ||
|
||
#!/bin/sh |
Copilot
AI
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate shebang line detected. Remove the second shebang on line 21 as the correct one is already present on line 1.
#!/bin/sh |
Copilot uses AI. Check for mistakes.
linux/update_vcpkg_client.sh
Outdated
# along with BOINC. If not, see <http://www.gnu.org/licenses/>. | ||
# | ||
|
||
#!/bin/sh |
Copilot
AI
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate shebang line detected. Remove the second shebang on line 21 as the correct one is already present on line 1.
#!/bin/sh |
Copilot uses AI. Check for mistakes.
linux/update_vcpkg_apps.sh
Outdated
# along with BOINC. If not, see <http://www.gnu.org/licenses/>. | ||
# | ||
|
||
#!/bin/sh |
Copilot
AI
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate shebang line detected. Remove the second shebang on line 21 as the correct one is already present on line 1.
#!/bin/sh |
Copilot uses AI. Check for mistakes.
linux/arm64/ci_configure_apps.sh
Outdated
# along with BOINC. If not, see <http://www.gnu.org/licenses/>. | ||
# | ||
|
||
#!/bin/sh |
Copilot
AI
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate shebang line detected. Remove the second shebang on line 21 as the correct one is already present on line 1.
#!/bin/sh |
Copilot uses AI. Check for mistakes.
aa727f5
to
84e107f
Compare
84e107f
to
490fb55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
export LD=aarch64-linux-gnu-ld | ||
export CFLAGS="-march=armv8-a -O3" | ||
export CXXFLAGS="-march=armv8-a -O3 -std=c++11" | ||
export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/" |
Copilot
AI
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CPPFLAGS export contains a duplicate include path. The -I$VCPKG_DIR/include
is specified twice, which is redundant.
export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/" | |
export CPPFLAGS="-I$VCPKG_DIR/include" |
Copilot uses AI. Check for mistakes.
export LD=aarch64-linux-gnu-ld | ||
export CFLAGS="-march=armv8-a -O3" | ||
export CXXFLAGS="-march=armv8-a -O3 -std=c++11" | ||
export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/" |
Copilot
AI
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CPPFLAGS export contains a duplicate include path. The -I$VCPKG_DIR/include
is specified twice, which is redundant.
export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/" | |
export CPPFLAGS="-I$VCPKG_DIR/include" |
Copilot uses AI. Check for mistakes.
export LD=aarch64-linux-gnu-ld | ||
export CFLAGS="-march=armv8-a -O3" | ||
export CXXFLAGS="-march=armv8-a -O3 -std=c++11" | ||
export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/" |
Copilot
AI
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CPPFLAGS export contains a duplicate include path. The -I$VCPKG_DIR/include
is specified twice, which is redundant.
export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/" | |
export CPPFLAGS="-I$VCPKG_DIR/include" |
Copilot uses AI. Check for mistakes.
export LD=aarch64-linux-gnu-ld | ||
export CFLAGS="-march=armv8-a -O3" | ||
export CXXFLAGS="-march=armv8-a -O3 -std=c++11" | ||
export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/" |
Copilot
AI
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CPPFLAGS export contains a duplicate include path. The -I$VCPKG_DIR/include
is specified twice, which is redundant.
export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/" | |
export CPPFLAGS="-I$VCPKG_DIR/include" |
Copilot uses AI. Check for mistakes.
7dbc8c2
to
9023250
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
export VCPKG_DIR="$VCPKG_ROOT/installed/$TRIPLET" | ||
export PKG_CONFIG_PATH=/usr/lib/aarch64-linux-gnu/pkgconfig/:$VCPKG_DIR/lib/pkgconfig/:$PKG_CONFIG_PATH | ||
|
||
linux/update_vcpkg_manager.sh $TRIPLET |
Copilot
AI
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script calls 'linux/update_vcpkg_manager.sh' but this file doesn't appear to exist in the codebase. Based on the pattern in other files, this should likely be 'linux/update_vcpkg_libs.sh' for manager builds.
linux/update_vcpkg_manager.sh $TRIPLET | |
linux/update_vcpkg_libs.sh $TRIPLET |
Copilot uses AI. Check for mistakes.
9023250
to
c767270
Compare
c767270
to
7368265
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 44 out of 44 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
boinc_types = { | ||
'linux_client': prepare_linux_client, | ||
'linux_client-vcpkg': prepare_linux_client_vcpkg, | ||
'android_apps': prepare_android_apps, | ||
'linux_apps': prepare_linux_apps, | ||
'linux_apps-arm64': prepare_linux_apps_arm64, | ||
'linux_apps-vcpkg-arm64': prepare_linux_apps_vcpkg_arm64, | ||
'linux_apps-vcpkg': prepare_linux_apps_vcpkg, | ||
'linux_apps-vcpkg-arm64': prepare_linux_apps_vcpkg_arm64, | ||
'linux_client': prepare_linux_client, | ||
'linux_client-vcpkg': prepare_linux_client_vcpkg, | ||
'linux_client-vcpkg-arm64': prepare_linux_client_vcpkg_arm64, | ||
'linux_manager': prepare_linux_manager, | ||
'linux_manager-with-webview': prepare_linux_manager_with_webview, | ||
'linux_manager-with-webview-vcpkg': prepare_linux_manager_with_webview_vcpkg, | ||
'linux_manager-with-webview-vcpkg-arm64': prepare_linux_manager_with_webview_vcpkg_arm64, | ||
'linux_manager-without-webview': prepare_linux_manager_without_webview, | ||
'logs': prepare_logs, | ||
'macos_manager': prepare_macos_apps, | ||
'macos_samples-makefile': prepare_macos_makefile_apps, | ||
'win_apps': prepare_win_apps, | ||
'win_apps-mingw': prepare_win_apps_mingw, | ||
'win_apps-mingw-vcpkg': prepare_win_apps_mingw_vcpkg, | ||
'android_apps': prepare_android_apps, | ||
'win_apps': prepare_win_apps, | ||
'win_client': prepare_win_client, | ||
'win_manager': prepare_win_manager, | ||
'win_installer': prepare_win_installer, | ||
'macos_manager': prepare_macos_apps, | ||
'macos_samples-makefile': prepare_macos_makefile_apps, | ||
'logs': prepare_logs, | ||
'win_manager': prepare_win_manager, | ||
} |
Copilot
AI
Oct 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The reorganization of the boinc_types dictionary by platform improves maintainability, but the alphabetical sorting within each platform section could be more consistent. Consider sorting all entries alphabetically within each platform grouping.
Copilot uses AI. Check for mistakes.
export LD=aarch64-linux-gnu-ld | ||
export CFLAGS="-march=armv8-a -O3" | ||
export CXXFLAGS="-march=armv8-a -O3 -std=c++11" | ||
export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/" |
Copilot
AI
Oct 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CPPFLAGS variable has a duplicate include path. The same directory is included twice: '-I$VCPKG_DIR/include -I$VCPKG_DIR/include/'. This is redundant and should be simplified to just '-I$VCPKG_DIR/include'.
export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/" | |
export CPPFLAGS="-I$VCPKG_DIR/include" |
Copilot uses AI. Check for mistakes.
export LD=aarch64-linux-gnu-ld | ||
export CFLAGS="-march=armv8-a -O3" | ||
export CXXFLAGS="-march=armv8-a -O3 -std=c++11" | ||
export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/" |
Copilot
AI
Oct 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CPPFLAGS variable has a duplicate include path. The same directory is included twice: '-I$VCPKG_DIR/include -I$VCPKG_DIR/include/'. This is redundant and should be simplified to just '-I$VCPKG_DIR/include'.
export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/" | |
export CPPFLAGS="-I$VCPKG_DIR/include" |
Copilot uses AI. Check for mistakes.
export LD=aarch64-linux-gnu-ld | ||
export CFLAGS="-march=armv8-a -O3" | ||
export CXXFLAGS="-march=armv8-a -O3 -std=c++11" | ||
export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/" |
Copilot
AI
Oct 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CPPFLAGS variable has a duplicate include path. The same directory is included twice: '-I$VCPKG_DIR/include -I$VCPKG_DIR/include/'. This is redundant and should be simplified to just '-I$VCPKG_DIR/include'.
export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/" | |
export CPPFLAGS="-I$VCPKG_DIR/include" |
Copilot uses AI. Check for mistakes.
export LD=aarch64-linux-gnu-ld | ||
export CFLAGS="-march=armv8-a -O3" | ||
export CXXFLAGS="-march=armv8-a -O3 -std=c++11" | ||
export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/" |
Copilot
AI
Oct 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CPPFLAGS variable has a duplicate include path. The same directory is included twice: '-I$VCPKG_DIR/include -I$VCPKG_DIR/include/'. This is redundant and should be simplified to just '-I$VCPKG_DIR/include'.
export CPPFLAGS="-I$VCPKG_DIR/include -I$VCPKG_DIR/include/" | |
export CPPFLAGS="-I$VCPKG_DIR/include" |
Copilot uses AI. Check for mistakes.
7368265
to
690f31b
Compare
690f31b
to
cdd80b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 45 out of 45 changed files in this pull request and generated 7 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fi | ||
|
||
TRIPLET="x64-linux" | ||
if [ ! -z "$1" ]; then |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use [ -n "$1" ]
instead of [ ! -z "$1" ]
for better readability and POSIX compliance.
if [ ! -z "$1" ]; then | |
if [ -n "$1" ]; then |
Copilot uses AI. Check for mistakes.
fi | ||
|
||
TRIPLET="x64-linux" | ||
if [ ! -z "$1" ]; then |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use [ -n "$1" ]
instead of [ ! -z "$1" ]
for better readability and POSIX compliance.
if [ ! -z "$1" ]; then | |
if [ -n "$1" ]; then |
Copilot uses AI. Check for mistakes.
fi | ||
|
||
TRIPLET="x64-linux" | ||
if [ ! -z "$1" ]; then |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use [ -n "$1" ]
instead of [ ! -z "$1" ]
for better readability and POSIX compliance.
if [ ! -z "$1" ]; then | |
if [ -n "$1" ]; then |
Copilot uses AI. Check for mistakes.
export VCPKG_DIR="$VCPKG_ROOT/installed/$TRIPLET" | ||
|
||
linux/arm64/update_vcpkg_libs.sh | ||
linux/update_vcpkg_libs.sh $TRIPLET |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quote the variable to prevent word splitting: linux/update_vcpkg_libs.sh \"$TRIPLET\"
linux/update_vcpkg_libs.sh $TRIPLET | |
linux/update_vcpkg_libs.sh "$TRIPLET" |
Copilot uses AI. Check for mistakes.
export VCPKG_DIR="$VCPKG_ROOT/installed/$TRIPLET" | ||
|
||
linux/arm64/update_vcpkg_apps.sh | ||
linux/update_vcpkg_apps.sh $TRIPLET |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quote the variable to prevent word splitting: linux/update_vcpkg_apps.sh \"$TRIPLET\"
linux/update_vcpkg_apps.sh $TRIPLET | |
linux/update_vcpkg_apps.sh "$TRIPLET" |
Copilot uses AI. Check for mistakes.
export VCPKG_DIR="$VCPKG_ROOT/installed/$TRIPLET" | ||
export PKG_CONFIG_PATH=$VCPKG_DIR/lib/pkgconfig/ | ||
|
||
linux/update_vcpkg_manager.sh $TRIPLET |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quote the variable to prevent word splitting: linux/update_vcpkg_manager.sh \"$TRIPLET\"
linux/update_vcpkg_manager.sh $TRIPLET | |
linux/update_vcpkg_manager.sh "$TRIPLET" |
Copilot uses AI. Check for mistakes.
VCPKG_ROOT="$BUILD_DIR/vcpkg" | ||
export VCPKG_DIR="$VCPKG_ROOT/installed/$TRIPLET" | ||
|
||
linux/update_vcpkg_client.sh $TRIPLET |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quote the variable to prevent word splitting: linux/update_vcpkg_client.sh \"$TRIPLET\"
linux/update_vcpkg_client.sh $TRIPLET | |
linux/update_vcpkg_client.sh "$TRIPLET" |
Copilot uses AI. Check for mistakes.
cdd80b6
to
efa2929
Compare
efa2929
to
a3de1a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 41 out of 41 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fi | ||
|
||
TRIPLET="x64-linux" | ||
if [ ! -z "$1" ]; then |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use more robust parameter checking. The construct [ ! -z "$1" ]
should be [ -n "$1" ]
for better readability and POSIX compliance.
if [ ! -z "$1" ]; then | |
if [ -n "$1" ]; then |
Copilot uses AI. Check for mistakes.
fi | ||
|
||
TRIPLET="x64-linux" | ||
if [ ! -z "$1" ]; then |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use more robust parameter checking. The construct [ ! -z "$1" ]
should be [ -n "$1" ]
for better readability and POSIX compliance.
if [ ! -z "$1" ]; then | |
if [ -n "$1" ]; then |
Copilot uses AI. Check for mistakes.
fi | ||
|
||
TRIPLET="x64-linux" | ||
if [ ! -z "$1" ]; then |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use more robust parameter checking. The construct [ ! -z "$1" ]
should be [ -n "$1" ]
for better readability and POSIX compliance.
if [ ! -z "$1" ]; then | |
if [ -n "$1" ]; then |
Copilot uses AI. Check for mistakes.
a3de1a9
to
709999b
Compare
709999b
to
d6dd4f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 41 out of 41 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
d6dd4f5
to
5e21701
Compare
5e21701
to
159a912
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 37 out of 37 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
export VCPKG_DIR="$VCPKG_ROOT/installed/$TRIPLET" | ||
|
||
linux/arm64/update_vcpkg_libs.sh | ||
linux/update_vcpkg_libs.sh $TRIPLET |
Copilot
AI
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script should quote the variable $TRIPLET
when passing it as an argument to prevent word splitting: linux/update_vcpkg_libs.sh \"$TRIPLET\"
linux/update_vcpkg_libs.sh $TRIPLET | |
linux/update_vcpkg_libs.sh "$TRIPLET" |
Copilot uses AI. Check for mistakes.
export VCPKG_DIR="$VCPKG_ROOT/installed/$TRIPLET" | ||
|
||
linux/arm64/update_vcpkg_apps.sh | ||
linux/update_vcpkg_apps.sh $TRIPLET |
Copilot
AI
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script should quote the variable $TRIPLET
when passing it as an argument to prevent word splitting: linux/update_vcpkg_apps.sh \"$TRIPLET\"
linux/update_vcpkg_apps.sh $TRIPLET | |
linux/update_vcpkg_apps.sh "$TRIPLET" |
Copilot uses AI. Check for mistakes.
VCPKG_ROOT="$BUILD_DIR/vcpkg" | ||
export VCPKG_DIR="$VCPKG_ROOT/installed/$TRIPLET" | ||
|
||
linux/update_vcpkg_client.sh $TRIPLET |
Copilot
AI
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script should quote the variable $TRIPLET
when passing it as an argument to prevent word splitting: linux/update_vcpkg_client.sh \"$TRIPLET\"
linux/update_vcpkg_client.sh $TRIPLET | |
linux/update_vcpkg_client.sh "$TRIPLET" |
Copilot uses AI. Check for mistakes.
159a912
to
7f0ac92
Compare
7f0ac92
to
55d1abd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 37 out of 37 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
'logs': prepare_logs, | ||
'win_manager': prepare_win_manager, | ||
} | ||
|
Copilot
AI
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The boinc_types dictionary is now alphabetically ordered, which improves maintainability, but the help() function still prints keys in dictionary order. Consider sorting the keys in the help function for consistent alphabetical output.
def help(): | |
print("Usage: prepare_deployment.py <BOINC_TYPE>") | |
print("Available BOINC_TYPEs:") | |
for key in sorted(boinc_types.keys()): | |
print(" " + key) |
Copilot uses AI. Check for mistakes.
55d1abd
to
d011564
Compare
d011564
to
1442be4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 36 out of 36 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.github/workflows/linux.yml
Outdated
if: ${{ failure() }} | ||
run: python3 ./deploy/prepare_deployment.py logs | ||
|
||
- name: boincmgr makefile upload fpr debugging |
Copilot
AI
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'fpr' to 'for'.
- name: boincmgr makefile upload fpr debugging | |
- name: boincmgr makefile upload for debugging |
Copilot uses AI. Check for mistakes.
1442be4
to
a557dc1
Compare
a557dc1
to
148c83d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 36 out of 36 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
148c83d
to
675da6e
Compare
Signed-off-by: Vitalii Koshura <[email protected]>
675da6e
to
7f99364
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 37 out of 37 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.