BUDA: support per-batch and per-job command-line args #5932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifies cmdline args for all jobs in batch; you can also specify per-job args, which come after. create_work: add logic to support the above; also fix bug involving pointers to stack vars (big no-no)
- file sandbox: add 'Get web file' option - docker wrapper: always write container log output to stderr - worker: write cmdline args to stderr - worker: version# is 4 - fix bug in file sandbox display - fix bug in BUDA variant delete - BUDA variant name defaults to 'cpu' - update examples files in samples/docker_wrapper/test_buda
file sandbox: use Location: to prevent repeating op on page reload BUDA: add explanatory text
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5932 +/- ##
============================================
- Coverage 10.73% 10.73% -0.01%
Complexity 1068 1068
============================================
Files 280 280
Lines 36618 36619 +1
Branches 8488 8489 +1
============================================
Hits 3930 3930
- Misses 32299 32300 +1
Partials 389 389
|
Signed-off-by: Vitalii Koshura <[email protected]>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (16)
- configure.ac: Language not supported
- html/inc/sandbox.inc: Language not supported
- html/user/buda.php: Language not supported
- html/user/buda_submit.php: Language not supported
- html/user/sandbox.php: Language not supported
- lib/str_util.cpp: Language not supported
- samples/docker_wrapper/docker_wrapper.cpp: Language not supported
- samples/docker_wrapper/test_buda/Dockerfile_worker_1: Language not supported
- samples/docker_wrapper/test_buda/Dockerfile_worker_2: Language not supported
- samples/docker_wrapper/test_buda/main_2.sh: Language not supported
- samples/docker_wrapper/test_buda/main_3.sh: Language not supported
- samples/worker/Makefile: Language not supported
- samples/worker/worker.cpp: Language not supported
- tools/create_work.cpp: Language not supported
- version.h: Language not supported
- win_build/worker.vcxproj: Language not supported
AenBleidd
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance create_work to support this.
Docker_wrapper copies stderr output of container.
Worker echoes its cmdline args.
Various improvements to user file sandbox and BUDA job submission interfaces.