[Windows][Installer] Clean-up installer project #5927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AenBleidd
commented
Nov 30, 2024
AenBleidd
commented
- Replace icons
- Remove unused dialog
- Remove SetAllUsers.dll
- Remove Print LA action (I don't believe anybody still uses it). If required - it could be always implemented.
- Replace ISSetupAllUsers 3rd-party function
- Remove unused icons
- Convert custom build target to custom build step to fix build of MSI file when only *.json file was changed.
- Remove SFHelper.dll
- Replace icons - Remove unused dialog - Remove SetAllUsers.dll - Remove Print LA action (I don't believe anybody still uses it). If required - it could be always implemented. - Replace ISSetupAllUsers 3rd-party function - Remove unused icons - Convert custom build target to custom build step to fix build of MSI file when only *.json file was changed. - Remove SFHelper.dll Signed-off-by: Vitalii Koshura <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 26 out of 36 changed files in this pull request and generated no suggestions.
Files not reviewed (10)
- clientsetup/win/CACCConfigMd5sum.cpp: Language not supported
- clientsetup/win/CACCConfigMd5sum.h: Language not supported
- clientsetup/win/CARestoreSetupState.cpp: Language not supported
- clientsetup/win/CAShutdownUD.cpp: Language not supported
- clientsetup/win/CAShutdownUD.h: Language not supported
- clientsetup/win/boinccas.def: Language not supported
- installer/installer_setup/main.cpp: Language not supported
- installer/locale/en.json: Language not supported
- win_build/boinccas.vcxproj: Language not supported
- win_build/installer.vcxproj: Language not supported
This was
linked to
issues
Nov 30, 2024
|
When you change UI specially on installer, that is the frontier of boinc for new users. You should add pictures to show how it look like, and wait for other people in community to review it. |
|
Not every change done by maintainers must be reviewed by the community. |
|
Thank you for the video. |
|
@talregev, I will not argue with you. Again. Read my previous message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.